]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
* lib/tcbfuncs.c: Avoid implicit signed to unsigned conversions.
authornekral-guest <nekral-guest@5a98b0ae-9ef6-0310-add3-de5d479b70d7>
Thu, 18 Mar 2010 00:03:48 +0000 (00:03 +0000)
committernekral-guest <nekral-guest@5a98b0ae-9ef6-0310-add3-de5d479b70d7>
Thu, 18 Mar 2010 00:03:48 +0000 (00:03 +0000)
ChangeLog
lib/tcbfuncs.c

index 4af996fabab97da09d36a031b0ebe78ead3af5bc..3c6faa604859879a76da1898af01d43b24e4403a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -14,6 +14,7 @@
        * lib/tcbfuncs.c: Include shadowio.h, needed for the
        spw_setdbname's prototype.
        * lib/tcbfuncs.c: Ignore fflush() return value.
+       * lib/tcbfuncs.c: Avoid implicit signed to unsigned conversions.
 
 2010-03-17  Nicolas François  <nicolas.francois@centraliens.net>
 
index 21833380db4c4d62241e1602a35db8fd57b196b9..b6518513a541c6333d8a96c8b82827d1bc1ea101 100644 (file)
@@ -101,7 +101,7 @@ static char *shadowtcb_path_rel_existing(const char *name)
        char *path, *rval;
        struct stat st;
        char link[8192];
-       int ret;
+       ssize_t ret;
 
        if (asprintf(&path, TCB_DIR "/%s", name) == -1) {
                OUT_OF_MEMORY;
@@ -133,12 +133,12 @@ static char *shadowtcb_path_rel_existing(const char *name)
                return NULL;
        }
        free(path);
-       if (ret >= sizeof(link) - 1) {
+       if ((size_t)ret >= sizeof(link) - 1) {
                link[sizeof(link) - 1] = '\0';
                fprintf(stderr, _("%s: Suspiciously long symlink: %s\n"), Prog, link);
                return NULL;
        }
-       link[ret] = '\0';
+       link[(size_t)ret] = '\0';
        rval = strdup(link);
        if (NULL == rval) {
                OUT_OF_MEMORY;