]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd/pm: fix missing device_attr cleanup in amdgpu_pm_sysfs_init()
authorYang Wang <kevinyang.wang@amd.com>
Thu, 30 Oct 2025 05:06:24 +0000 (13:06 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 4 Nov 2025 18:18:05 +0000 (13:18 -0500)
Use the correct label to complete all cleanup work.

Fixes: 4d154b1ca580 ("drm/amd/pm: Add support for DPM policies")
Fixes: 25e82f2e2c59 ("drm/amd/pm: Add temperature metrics sysfs entry")
Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 4c4c138a1c86775c4d47e24f26357a1f8b64d0a3)

drivers/gpu/drm/amd/pm/amdgpu_pm.c

index b5fbb0fd1dc090b3498adef756c6887f656bf971..a7e6d7854b7b2cf8a46ed53b09252a91f747ca3d 100644 (file)
@@ -4724,14 +4724,14 @@ int amdgpu_pm_sysfs_init(struct amdgpu_device *adev)
                ret = devm_device_add_group(adev->dev,
                                            &amdgpu_pm_policy_attr_group);
                if (ret)
-                       goto err_out0;
+                       goto err_out1;
        }
 
        if (amdgpu_dpm_is_temp_metrics_supported(adev, SMU_TEMP_METRIC_GPUBOARD)) {
                ret = devm_device_add_group(adev->dev,
                                            &amdgpu_board_attr_group);
                if (ret)
-                       goto err_out0;
+                       goto err_out1;
                if (amdgpu_pm_get_sensor_generic(adev, AMDGPU_PP_SENSOR_MAXNODEPOWERLIMIT,
                                                 (void *)&tmp) != -EOPNOTSUPP) {
                        sysfs_add_file_to_group(&adev->dev->kobj,