]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli: Simplify sddl_decode_err_msg()
authorVolker Lendecke <vl@samba.org>
Wed, 27 Nov 2024 11:37:21 +0000 (12:37 +0100)
committerVolker Lendecke <vl@samba.org>
Tue, 3 Dec 2024 08:01:30 +0000 (08:01 +0000)
We have security_descriptor_initialise() for this

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
libcli/security/sddl.c

index c0fddb72e5f0b41b34b32107e1f3db1ca7d47032..c2a6ca26fc31b0498829b27e11f4552ee39f6ca8 100644 (file)
@@ -923,12 +923,10 @@ struct security_descriptor *sddl_decode_err_msg(TALLOC_CTX *mem_ctx, const char
        *msg = NULL;
        *msg_offset = 0;
 
-       sd = talloc_zero(mem_ctx, struct security_descriptor);
+       sd = security_descriptor_initialise(mem_ctx);
        if (sd == NULL) {
                return NULL;
        }
-       sd->revision = SECURITY_DESCRIPTOR_REVISION_1;
-       sd->type     = SEC_DESC_SELF_RELATIVE;
 
        while (*sddl) {
                uint32_t flags;