]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: lpfc: Remove deprecated PBDE feature
authorJustin Tee <justin.tee@broadcom.com>
Tue, 31 Mar 2026 20:59:23 +0000 (13:59 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 3 Apr 2026 01:34:02 +0000 (21:34 -0400)
The PBDE feature is no longer supported and its related fields are removed
in this patch.  There are no expected side effects with regards to existing
functionality.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://patch.msgid.link/20260331205928.119833-6-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc.h
drivers/scsi/lpfc/lpfc_attr.c
drivers/scsi/lpfc/lpfc_hw4.h
drivers/scsi/lpfc/lpfc_init.c
drivers/scsi/lpfc/lpfc_mbox.c
drivers/scsi/lpfc/lpfc_nvme.c
drivers/scsi/lpfc/lpfc_nvmet.c
drivers/scsi/lpfc/lpfc_scsi.c
drivers/scsi/lpfc/lpfc_sli.c

index 689793d03c20b4c46e17577a48fea2ae2c8d4fd4..c92b96d0c325226e1f71e9e36885f53b95b83087 100644 (file)
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2025 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2026 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
@@ -1017,7 +1017,6 @@ struct lpfc_hba {
 #define LPFC_SLI3_CRP_ENABLED          0x08
 #define LPFC_SLI3_BG_ENABLED           0x20
 #define LPFC_SLI3_DSS_ENABLED          0x40
-#define LPFC_SLI4_PERFH_ENABLED                0x80
 #define LPFC_SLI4_PHWQ_ENABLED         0x100
        uint32_t iocb_cmd_size;
        uint32_t iocb_rsp_size;
@@ -1190,7 +1189,6 @@ struct lpfc_hba {
        uint32_t cfg_ras_fwlog_func;
        uint32_t cfg_enable_bbcr;       /* Enable BB Credit Recovery */
        uint32_t cfg_enable_dpp;        /* Enable Direct Packet Push */
-       uint32_t cfg_enable_pbde;
        uint32_t cfg_enable_mi;
        struct nvmet_fc_target_port *targetport;
        lpfc_vpd_t vpd;         /* vital product data */
index 53f41d68e0d850eb265f52e104a6eead053095c1..9f7df51f893d0e4a8760d8a44ed623701614892b 100644 (file)
@@ -1,8 +1,8 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2025 Broadcom. All Rights Reserved. The term *
- * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.  *
+ * Copyright (C) 2017-2026 Broadcom. All Rights Reserved. The term *
+ * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
  * www.broadcom.com                                                *
@@ -7467,8 +7467,6 @@ lpfc_get_cfgparam(struct lpfc_hba *phba)
 
        phba->cfg_auto_imax = (phba->cfg_fcp_imax) ? 0 : 1;
 
-       phba->cfg_enable_pbde = 0;
-
        /* A value of 0 means use the number of CPUs found in the system */
        if (phba->cfg_hdw_queue == 0)
                phba->cfg_hdw_queue = phba->sli4_hba.num_present_cpu;
index c000474c3066df0a63dc87b3a47ca0a907c8e4d5..0e11701b0881dfaea20a4033a3df2f8a9d5db718 100644 (file)
@@ -1,8 +1,8 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2025 Broadcom. All Rights Reserved. The term *
- * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.  *
+ * Copyright (C) 2017-2026 Broadcom. All Rights Reserved. The term *
+ * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2009-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
  * www.broadcom.com                                                *
@@ -3062,9 +3062,6 @@ struct lpfc_mbx_request_features {
 #define lpfc_mbx_rq_ftr_rq_iaar_SHIFT          9
 #define lpfc_mbx_rq_ftr_rq_iaar_MASK           0x00000001
 #define lpfc_mbx_rq_ftr_rq_iaar_WORD           word2
-#define lpfc_mbx_rq_ftr_rq_perfh_SHIFT         11
-#define lpfc_mbx_rq_ftr_rq_perfh_MASK          0x00000001
-#define lpfc_mbx_rq_ftr_rq_perfh_WORD          word2
 #define lpfc_mbx_rq_ftr_rq_mrqp_SHIFT          16
 #define lpfc_mbx_rq_ftr_rq_mrqp_MASK           0x00000001
 #define lpfc_mbx_rq_ftr_rq_mrqp_WORD           word2
@@ -3096,9 +3093,6 @@ struct lpfc_mbx_request_features {
 #define lpfc_mbx_rq_ftr_rsp_ifip_SHIFT         7
 #define lpfc_mbx_rq_ftr_rsp_ifip_MASK          0x00000001
 #define lpfc_mbx_rq_ftr_rsp_ifip_WORD          word3
-#define lpfc_mbx_rq_ftr_rsp_perfh_SHIFT                11
-#define lpfc_mbx_rq_ftr_rsp_perfh_MASK         0x00000001
-#define lpfc_mbx_rq_ftr_rsp_perfh_WORD         word3
 #define lpfc_mbx_rq_ftr_rsp_mrqp_SHIFT         16
 #define lpfc_mbx_rq_ftr_rsp_mrqp_MASK          0x00000001
 #define lpfc_mbx_rq_ftr_rsp_mrqp_WORD          word3
@@ -3461,10 +3455,6 @@ struct lpfc_sli4_parameters {
 #define cfg_pvl_MASK                           0x00000001
 #define cfg_pvl_WORD                           word19
 
-#define cfg_pbde_SHIFT                         20
-#define cfg_pbde_MASK                          0x00000001
-#define cfg_pbde_WORD                          word19
-
        uint32_t word20;
 #define cfg_max_tow_xri_SHIFT                  0
 #define cfg_max_tow_xri_MASK                   0x0000ffff
@@ -4484,9 +4474,6 @@ struct wqe_common {
 #define wqe_irsp_SHIFT        4
 #define wqe_irsp_MASK         0x00000001
 #define wqe_irsp_WORD         word11
-#define wqe_pbde_SHIFT        5
-#define wqe_pbde_MASK         0x00000001
-#define wqe_pbde_WORD         word11
 #define wqe_sup_SHIFT         6
 #define wqe_sup_MASK          0x00000001
 #define wqe_sup_WORD          word11
index 6bfc57d21c57c85aec50f999ee128b4db5fdc0d9..dd07b1de0cdbada2f244808d33d5803cfc0a5ad7 100644 (file)
@@ -13822,12 +13822,6 @@ fcponly:
        if (phba->cfg_enable_fc4_type & LPFC_ENABLE_NVME)
                phba->cfg_sg_seg_cnt = LPFC_MAX_NVME_SEG_CNT;
 
-       /* Enable embedded Payload BDE if support is indicated */
-       if (bf_get(cfg_pbde, mbx_sli4_parameters))
-               phba->cfg_enable_pbde = 1;
-       else
-               phba->cfg_enable_pbde = 0;
-
        /*
         * To support Suppress Response feature we must satisfy 3 conditions.
         * lpfc_suppress_rsp module parameter must be set (default).
@@ -13862,9 +13856,8 @@ fcponly:
                phba->fcp_embed_io = 0;
 
        lpfc_printf_log(phba, KERN_INFO, LOG_INIT | LOG_NVME,
-                       "6422 XIB %d PBDE %d: FCP %d NVME %d %d %d\n",
+                       "6422 XIB %d: FCP %d NVME %d %d %d\n",
                        bf_get(cfg_xib, mbx_sli4_parameters),
-                       phba->cfg_enable_pbde,
                        phba->fcp_embed_io, sli4_params->nvme,
                        phba->cfg_nvme_embed_cmd, phba->cfg_suppress_rsp);
 
index d07c2786cb1211dd5a7653d20f265cbfadd67a11..572db734880676b2e3497cae3c52fe522914c751 100644 (file)
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2026 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
@@ -2139,7 +2139,6 @@ lpfc_request_features(struct lpfc_hba *phba, struct lpfcMboxq *mboxq)
 
        /* Set up host requested features. */
        bf_set(lpfc_mbx_rq_ftr_rq_fcpi, &mboxq->u.mqe.un.req_ftrs, 1);
-       bf_set(lpfc_mbx_rq_ftr_rq_perfh, &mboxq->u.mqe.un.req_ftrs, 1);
 
        /* Enable DIF (block guard) only if configured to do so. */
        if (phba->cfg_enable_bg)
index 74c2820c64f3a5e8f3a398f1c84f519e4ccced9d..81b8fe69f2bceb9ddbedc3e0dba6b7e074dd7d74 100644 (file)
@@ -1296,8 +1296,6 @@ lpfc_nvme_prep_io_cmd(struct lpfc_vport *vport,
        /* Word 10 */
        bf_set(wqe_xchg, &wqe->fcp_iwrite.wqe_com, LPFC_NVME_XCHG);
 
-       /* Words 13 14 15 are for PBDE support */
-
        /* add the VMID tags as per switch response */
        if (unlikely(lpfc_ncmd->cur_iocbq.cmd_flag & LPFC_IO_VMID)) {
                if (phba->pport->vmid_priority_tagging) {
@@ -1335,12 +1333,9 @@ lpfc_nvme_prep_io_dma(struct lpfc_vport *vport,
 {
        struct lpfc_hba *phba = vport->phba;
        struct nvmefc_fcp_req *nCmd = lpfc_ncmd->nvmeCmd;
-       union lpfc_wqe128 *wqe = &lpfc_ncmd->cur_iocbq.wqe;
        struct sli4_sge *sgl = lpfc_ncmd->dma_sgl;
        struct sli4_hybrid_sgl *sgl_xtra = NULL;
        struct scatterlist *data_sg;
-       struct sli4_sge *first_data_sgl;
-       struct ulp_bde64 *bde;
        dma_addr_t physaddr = 0;
        uint32_t dma_len = 0;
        uint32_t dma_offset = 0;
@@ -1361,7 +1356,6 @@ lpfc_nvme_prep_io_dma(struct lpfc_vport *vport,
                 */
                sgl += 2;
 
-               first_data_sgl = sgl;
                lpfc_ncmd->seg_cnt = nCmd->sg_cnt;
                if (lpfc_ncmd->seg_cnt > lpfc_nvme_template.max_sgl_segments) {
                        lpfc_printf_log(phba, KERN_ERR, LOG_TRACE_EVENT,
@@ -1464,26 +1458,6 @@ lpfc_nvme_prep_io_dma(struct lpfc_vport *vport,
 
                        j++;
                }
-
-               /* PBDE support for first data SGE only */
-               if (nseg == 1 && phba->cfg_enable_pbde) {
-                       /* Words 13-15 */
-                       bde = (struct ulp_bde64 *)
-                               &wqe->words[13];
-                       bde->addrLow = first_data_sgl->addr_lo;
-                       bde->addrHigh = first_data_sgl->addr_hi;
-                       bde->tus.f.bdeSize =
-                               le32_to_cpu(first_data_sgl->sge_len);
-                       bde->tus.f.bdeFlags = BUFF_TYPE_BDE_64;
-                       bde->tus.w = cpu_to_le32(bde->tus.w);
-
-                       /* Word 11 - set PBDE bit */
-                       bf_set(wqe_pbde, &wqe->generic.wqe_com, 1);
-               } else {
-                       memset(&wqe->words[13], 0, (sizeof(uint32_t) * 3));
-                       /* Word 11 - PBDE bit disabled by default template */
-               }
-
        } else {
                lpfc_ncmd->seg_cnt = 0;
 
index debd9317103a7592867367d39072a8721d3dabb1..72f3f6f9444dabadfa6ae25f9383b5bde2cb80d4 100644 (file)
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2026 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
@@ -118,12 +118,9 @@ lpfc_nvmet_cmd_template(void)
        bf_set(wqe_sup, &wqe->fcp_tsend.wqe_com, 0);
        bf_set(wqe_irsp, &wqe->fcp_tsend.wqe_com, 0);
        bf_set(wqe_irsplen, &wqe->fcp_tsend.wqe_com, 0);
-       bf_set(wqe_pbde, &wqe->fcp_tsend.wqe_com, 0);
 
        /* Word 12 - fcp_data_len is variable */
 
-       /* Word 13, 14, 15 - PBDE is zero */
-
        /* TRECEIVE template */
        wqe = &lpfc_treceive_cmd_template;
        memset(wqe, 0, sizeof(union lpfc_wqe128));
@@ -158,18 +155,15 @@ lpfc_nvmet_cmd_template(void)
        bf_set(wqe_lenloc, &wqe->fcp_treceive.wqe_com, LPFC_WQE_LENLOC_WORD12);
        bf_set(wqe_xc, &wqe->fcp_tsend.wqe_com, 1);
 
-       /* Word 11 - pbde is variable */
+       /* Word 11 */
        bf_set(wqe_cmd_type, &wqe->fcp_treceive.wqe_com, FCP_COMMAND_TRECEIVE);
        bf_set(wqe_cqid, &wqe->fcp_treceive.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
        bf_set(wqe_sup, &wqe->fcp_treceive.wqe_com, 0);
        bf_set(wqe_irsp, &wqe->fcp_treceive.wqe_com, 0);
        bf_set(wqe_irsplen, &wqe->fcp_treceive.wqe_com, 0);
-       bf_set(wqe_pbde, &wqe->fcp_treceive.wqe_com, 1);
 
        /* Word 12 - fcp_data_len is variable */
 
-       /* Word 13, 14, 15 - PBDE is variable */
-
        /* TRSP template */
        wqe = &lpfc_trsp_cmd_template;
        memset(wqe, 0, sizeof(union lpfc_wqe128));
@@ -207,7 +201,6 @@ lpfc_nvmet_cmd_template(void)
        bf_set(wqe_sup, &wqe->fcp_trsp.wqe_com, 0);
        bf_set(wqe_irsp, &wqe->fcp_trsp.wqe_com, 0);
        bf_set(wqe_irsplen, &wqe->fcp_trsp.wqe_com, 0);
-       bf_set(wqe_pbde, &wqe->fcp_trsp.wqe_com, 0);
 
        /* Word 12, 13, 14, 15 - is zero */
 }
@@ -2722,7 +2715,6 @@ lpfc_nvmet_prep_fcp_wqe(struct lpfc_hba *phba,
        struct ulp_bde64 *bde;
        dma_addr_t physaddr;
        int i, cnt, nsegs;
-       bool use_pbde = false;
        int xc = 1;
 
        if (!lpfc_is_link_up(phba)) {
@@ -2907,15 +2899,6 @@ lpfc_nvmet_prep_fcp_wqe(struct lpfc_hba *phba,
                if (!xc)
                        bf_set(wqe_xc, &wqe->fcp_treceive.wqe_com, 0);
 
-               /* Word 11 - check for pbde */
-               if (nsegs == 1 && phba->cfg_enable_pbde) {
-                       use_pbde = true;
-                       /* Word 11 - PBDE bit already preset by template */
-               } else {
-                       /* Overwrite default template setting */
-                       bf_set(wqe_pbde, &wqe->fcp_treceive.wqe_com, 0);
-               }
-
                /* Word 12 */
                wqe->fcp_tsend.fcp_data_len = rsp->transfer_length;
 
@@ -3023,19 +3006,9 @@ lpfc_nvmet_prep_fcp_wqe(struct lpfc_hba *phba,
        }
 
        bde = (struct ulp_bde64 *)&wqe->words[13];
-       if (use_pbde) {
-               /* decrement sgl ptr backwards once to first data sge */
-               sgl--;
-
-               /* Words 13-15 (PBDE) */
-               bde->addrLow = sgl->addr_lo;
-               bde->addrHigh = sgl->addr_hi;
-               bde->tus.f.bdeSize = le32_to_cpu(sgl->sge_len);
-               bde->tus.f.bdeFlags = BUFF_TYPE_BDE_64;
-               bde->tus.w = cpu_to_le32(bde->tus.w);
-       } else {
-               memset(bde, 0, sizeof(struct ulp_bde64));
-       }
+
+       memset(bde, 0, sizeof(struct ulp_bde64));
+
        ctxp->state = LPFC_NVME_STE_DATA;
        ctxp->entry_cnt++;
        return nvmewqe;
index e9d27703bc44734c3565b37408287bfd3a826525..f11f2c29db8923930dd0bc477dcfcb8f03164d68 100644 (file)
@@ -3050,7 +3050,6 @@ lpfc_scsi_prep_dma_buf_s4(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
        struct scatterlist *sgel = NULL;
        struct fcp_cmnd *fcp_cmnd = lpfc_cmd->fcp_cmnd;
        struct sli4_sge *sgl = (struct sli4_sge *)lpfc_cmd->dma_sgl;
-       struct sli4_sge *first_data_sgl;
        struct lpfc_iocbq *pwqeq = &lpfc_cmd->cur_iocbq;
        struct lpfc_vport *vport = phba->pport;
        union lpfc_wqe128 *wqe = &pwqeq->wqe;
@@ -3058,7 +3057,6 @@ lpfc_scsi_prep_dma_buf_s4(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
        uint32_t dma_len;
        uint32_t dma_offset = 0;
        int nseg, i, j;
-       struct ulp_bde64 *bde;
        bool lsp_just_set = false;
        struct sli4_hybrid_sgl *sgl_xtra = NULL;
 
@@ -3085,7 +3083,6 @@ lpfc_scsi_prep_dma_buf_s4(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
                bf_set(lpfc_sli4_sge_last, sgl, 0);
                sgl->word2 = cpu_to_le32(sgl->word2);
                sgl += 1;
-               first_data_sgl = sgl;
                lpfc_cmd->seg_cnt = nseg;
                if (!phba->cfg_xpsgl &&
                    lpfc_cmd->seg_cnt > phba->cfg_sg_seg_cnt) {
@@ -3185,43 +3182,12 @@ lpfc_scsi_prep_dma_buf_s4(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
 
                        j++;
                }
-
-               /* PBDE support for first data SGE only.
-                * For FCoE, we key off Performance Hints.
-                * For FC, we key off lpfc_enable_pbde.
-                */
-               if (nseg == 1 &&
-                   ((phba->sli3_options & LPFC_SLI4_PERFH_ENABLED) ||
-                    phba->cfg_enable_pbde)) {
-                       /* Words 13-15 */
-                       bde = (struct ulp_bde64 *)
-                               &wqe->words[13];
-                       bde->addrLow = first_data_sgl->addr_lo;
-                       bde->addrHigh = first_data_sgl->addr_hi;
-                       bde->tus.f.bdeSize =
-                                       le32_to_cpu(first_data_sgl->sge_len);
-                       bde->tus.f.bdeFlags = BUFF_TYPE_BDE_64;
-                       bde->tus.w = cpu_to_le32(bde->tus.w);
-
-                       /* Word 11 - set PBDE bit */
-                       bf_set(wqe_pbde, &wqe->generic.wqe_com, 1);
-               } else {
-                       memset(&wqe->words[13], 0, (sizeof(uint32_t) * 3));
-                       /* Word 11 - PBDE bit disabled by default template */
-               }
        } else {
                sgl += 1;
                /* set the last flag in the fcp_rsp map entry */
                sgl->word2 = le32_to_cpu(sgl->word2);
                bf_set(lpfc_sli4_sge_last, sgl, 1);
                sgl->word2 = cpu_to_le32(sgl->word2);
-
-               if ((phba->sli3_options & LPFC_SLI4_PERFH_ENABLED) ||
-                   phba->cfg_enable_pbde) {
-                       bde = (struct ulp_bde64 *)
-                               &wqe->words[13];
-                       memset(bde, 0, (sizeof(uint32_t) * 3));
-               }
        }
 
        /*
index b32a1870eec2ac3f68a9d2e2baa7a0bccc42ea4a..41a73ffd34e1f3dfc64b4da258ad5755bab3c282 100644 (file)
@@ -136,15 +136,12 @@ void lpfc_wqe_cmd_template(void)
        bf_set(wqe_dbde, &wqe->fcp_iread.wqe_com, 0);
        bf_set(wqe_wqes, &wqe->fcp_iread.wqe_com, 1);
 
-       /* Word 11 - pbde is variable */
+       /* Word 11 */
        bf_set(wqe_cmd_type, &wqe->fcp_iread.wqe_com, COMMAND_DATA_IN);
        bf_set(wqe_cqid, &wqe->fcp_iread.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
-       bf_set(wqe_pbde, &wqe->fcp_iread.wqe_com, 0);
 
        /* Word 12 - is zero */
 
-       /* Word 13, 14, 15 - PBDE is variable */
-
        /* IWRITE template */
        wqe = &lpfc_iwrite_cmd_template;
        memset(wqe, 0, sizeof(union lpfc_wqe128));
@@ -176,15 +173,12 @@ void lpfc_wqe_cmd_template(void)
        bf_set(wqe_dbde, &wqe->fcp_iwrite.wqe_com, 0);
        bf_set(wqe_wqes, &wqe->fcp_iwrite.wqe_com, 1);
 
-       /* Word 11 - pbde is variable */
+       /* Word 11 */
        bf_set(wqe_cmd_type, &wqe->fcp_iwrite.wqe_com, COMMAND_DATA_OUT);
        bf_set(wqe_cqid, &wqe->fcp_iwrite.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
-       bf_set(wqe_pbde, &wqe->fcp_iwrite.wqe_com, 0);
 
        /* Word 12 - is zero */
 
-       /* Word 13, 14, 15 - PBDE is variable */
-
        /* ICMND template */
        wqe = &lpfc_icmnd_cmd_template;
        memset(wqe, 0, sizeof(union lpfc_wqe128));
@@ -217,7 +211,6 @@ void lpfc_wqe_cmd_template(void)
        /* Word 11 */
        bf_set(wqe_cmd_type, &wqe->fcp_icmd.wqe_com, COMMAND_DATA_IN);
        bf_set(wqe_cqid, &wqe->fcp_icmd.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
-       bf_set(wqe_pbde, &wqe->fcp_icmd.wqe_com, 0);
 
        /* Word 12, 13, 14, 15 - is zero */
 }
@@ -8732,14 +8725,6 @@ lpfc_sli4_hba_setup(struct lpfc_hba *phba)
                ftr_rsp++;
        }
 
-       /* Performance Hints are ONLY for FCoE */
-       if (test_bit(HBA_FCOE_MODE, &phba->hba_flag)) {
-               if (bf_get(lpfc_mbx_rq_ftr_rsp_perfh, &mqe->un.req_ftrs))
-                       phba->sli3_options |= LPFC_SLI4_PERFH_ENABLED;
-               else
-                       phba->sli3_options &= ~LPFC_SLI4_PERFH_ENABLED;
-       }
-
        /*
         * If the port cannot support the host's requested features
         * then turn off the global config parameters to disable the