]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
winexe: Make sure specificError is initialized
authorAndreas Schneider <asn@samba.org>
Thu, 20 Jun 2024 07:08:48 +0000 (09:08 +0200)
committerMartin Schwenke <martins@samba.org>
Sun, 30 Jun 2024 23:20:33 +0000 (23:20 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/examples/winexe/winexesvc.c:684: var_decl: Declaring variable ""specificError"" without initializer.
samba-4.20.0rc2/examples/winexe/winexesvc.c:711: uninit_use: Using uninitialized value ""specificError"".
  709|    winexesvcStatus.dwWaitHint = 0;
  710|    winexesvcStatus.dwWin32ExitCode = status;
  711|->  winexesvcStatus.dwServiceSpecificExitCode = specificError;
  712|
  713|    SetServiceStatus(winexesvcStatusHandle, &winexesvcStatus);"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
examples/winexe/winexesvc.c

index 3d2ebcce149379e22143cb1295ee3812ae337c21..980f4d1ab6dc681beb19f2a51789ad00a2bb66fe 100644 (file)
@@ -681,7 +681,7 @@ static DWORD winexesvcInitialization(DWORD argc, LPTSTR * argv, DWORD * specific
 static void WINAPI winexesvcStart(DWORD argc, LPTSTR * argv)
 {
        DWORD status;
-       DWORD specificError;
+       DWORD specificError = NO_ERROR;
 
        winexesvcStatus.dwServiceType = SERVICE_WIN32;
        winexesvcStatus.dwCurrentState = SERVICE_START_PENDING;