]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: make use of SD_ENUM_FORCE_S64() for all public enums 18557/head
authorLennart Poettering <lennart@poettering.net>
Thu, 11 Feb 2021 15:04:08 +0000 (16:04 +0100)
committerLennart Poettering <lennart@poettering.net>
Tue, 16 Feb 2021 19:36:52 +0000 (20:36 +0100)
src/network/test-network-tables.c
src/shared/wifi-util.c
src/systemd/sd-dhcp-lease.h
src/systemd/sd-lldp.h
src/systemd/sd-ndisc.h
src/systemd/sd-netlink.h

index 475cac7527b2c2626ef9c89641bc1a272b68dbdd..b1d934a3c40230420f2d7095761aa88112eaa82b 100644 (file)
@@ -40,10 +40,16 @@ int main(int argc, char **argv) {
         test_table(wol, WOL);
         test_table(lldp_event, SD_LLDP_EVENT);
         test_table(ndisc_event, SD_NDISC_EVENT);
+        test_table(dhcp_lease_server_type, SD_DHCP_LEASE_SERVER_TYPE);
 
         test_table_sparse(ipvlan_mode, NETDEV_IPVLAN_MODE);
         test_table_sparse(macvlan_mode, NETDEV_MACVLAN_MODE);
         test_table_sparse(address_family, ADDRESS_FAMILY);
 
+        assert_cc(sizeof(sd_lldp_event) == sizeof(int64_t));
+        assert_cc(sizeof(sd_ndisc_event) == sizeof(int64_t));
+        assert_cc(sizeof(sd_dhcp_lease_server_type) == sizeof(int64_t));
+        assert_cc(sizeof(sd_genl_family) == sizeof(int64_t));
+
         return EXIT_SUCCESS;
 }
index 2ac8846004335ed2e2e0474a8bcc9c0a2f37bbbf..5caa95f3d2f500327123a46a37768c4481d8b7a3 100644 (file)
@@ -42,7 +42,7 @@ int wifi_get_interface(sd_netlink *genl, int ifindex, enum nl80211_iftype *iftyp
         if (r < 0)
                 return log_debug_errno(r, "Failed to determine genl family: %m");
         if (family != SD_GENL_NL80211) {
-                log_debug("Received message of unexpected genl family %u, ignoring.", family);
+                log_debug("Received message of unexpected genl family %" PRIi64 ", ignoring.", family);
                 goto nodata;
         }
 
@@ -110,7 +110,7 @@ int wifi_get_station(sd_netlink *genl, int ifindex, struct ether_addr *bssid) {
         if (r < 0)
                 return log_debug_errno(r, "Failed to determine genl family: %m");
         if (family != SD_GENL_NL80211) {
-                log_debug("Received message of unexpected genl family %u, ignoring.", family);
+                log_debug("Received message of unexpected genl family %" PRIi64 ", ignoring.", family);
                 goto nodata;
         }
 
index 2c6c0a981dae7a165e93882b7fb97db2f0ff6d89..ca2da7920d6f4d774ad78f22875ee684b5449bab 100644 (file)
@@ -43,6 +43,7 @@ typedef enum sd_dhcp_lease_server_type {
         SD_DHCP_LEASE_LPR,
         _SD_DHCP_LEASE_SERVER_TYPE_MAX,
         _SD_DHCP_LEASE_SERVER_TYPE_INVALID = -EINVAL,
+        _SD_ENUM_FORCE_S64(DHCP_LEASE_SERVER_TYPE),
 } sd_dhcp_lease_server_type;
 
 int sd_dhcp_lease_get_address(sd_dhcp_lease *lease, struct in_addr *addr);
index 296a8201a2f7d397dc4ecfc1f65ed45f83866748..88652bc2c679856c2b777961064a2aa674909897 100644 (file)
@@ -129,6 +129,7 @@ typedef enum sd_lldp_event {
         SD_LLDP_EVENT_REFRESHED,
         _SD_LLDP_EVENT_MAX,
         _SD_LLDP_EVENT_INVALID = -EINVAL,
+        _SD_ENUM_FORCE_S64(LLDP_EVENT),
 } sd_lldp_event;
 
 typedef void (*sd_lldp_callback_t)(sd_lldp *lldp, sd_lldp_event event, sd_lldp_neighbor *n, void *userdata);
index f96bfc39eaa7611f63e3a1902edc2610134e671f..22e97d8ff7c2ac9da19e3f21e570e7b9e0908013 100644 (file)
@@ -60,6 +60,7 @@ typedef enum sd_ndisc_event {
         SD_NDISC_EVENT_ROUTER,
         _SD_NDISC_EVENT_MAX,
         _SD_NDISC_EVENT_INVALID = -EINVAL,
+        _SD_ENUM_FORCE_S64(NDISC_EVENT),
 } sd_ndisc_event;
 
 typedef void (*sd_ndisc_callback_t)(sd_ndisc *nd, sd_ndisc_event event, sd_ndisc_router *rt, void *userdata);
index 13b00d6a5b54f056455193112db219af0c3786bc..18a88a36be49db619a96ff947182fe5aee9764b2 100644 (file)
@@ -17,6 +17,7 @@
   along with systemd; If not, see <http://www.gnu.org/licenses/>.
 ***/
 
+#include <errno.h>
 #include <inttypes.h>
 #include <net/ethernet.h>
 #include <netinet/in.h>
@@ -34,7 +35,7 @@ typedef struct sd_genl_socket sd_genl_socket;
 typedef struct sd_netlink_message sd_netlink_message;
 typedef struct sd_netlink_slot sd_netlink_slot;
 
-typedef enum sd_gen_family {
+typedef enum sd_genl_family {
         SD_GENL_ERROR,
         SD_GENL_DONE,
         SD_GENL_ID_CTRL,
@@ -43,6 +44,9 @@ typedef enum sd_gen_family {
         SD_GENL_L2TP,
         SD_GENL_MACSEC,
         SD_GENL_NL80211,
+        _SD_GENL_FAMILY_MAX,
+        _SD_GENL_FAMILY_INVALID = -EINVAL,
+        _SD_ENUM_FORCE_S64(GENL_FAMILY)
 } sd_genl_family;
 
 /* callback */