Include check on polpermissive relcache for policies

equalPolicy() is used in the relation cache to check if two policy
definitions are equivalent, but missed to check for polpermissive.

ALTER POLICY cannot switch a policy to be PERMISSIVE or RESTRICTIVE, so
this would need a dropped and then re-created policy, which would
trigger a relcache invalidation.  Anyway, there is no harm in being
consistent in the check, and if one decides to add an ALTER POLICY to
switch PERMISSIVE or RESTRICTIVE, we would be silently in trouble.

Author: Andreas Lind <andreaslindpetersen@gmail.com>
Reviewed-by: Laurenz Albe <laurenz.albe@cybertec.at>
Discussion: https://postgr.es/m/CAMxA3rv1CS6R7JR5ojz-3CmCEnZEFrqu+XXTnGbLRWrjJRH7sA@mail.gmail.com
Backpatch-through: 14

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 264b32270bff90fa26cdb869e041772e27953066..86cc0f93389fc88eecb62941d5ead3c125f2ac35 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -961,6 +961,8 @@ equalPolicy(RowSecurityPolicy *policy1, RowSecurityPolicy *policy2)
 
                if (policy1->polcmd != policy2->polcmd)
                        return false;
+               if (policy1->permissive != policy2->permissive)
+                       return false;
                if (policy1->hassublinks != policy2->hassublinks)
                        return false;
                if (strcmp(policy1->policy_name, policy2->policy_name) != 0)