]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
source3/script: Fix installation of winbind_ctdb_updatekeytab.sh
authorAnoop C S <anoopcs@samba.org>
Wed, 14 Aug 2024 14:17:35 +0000 (19:47 +0530)
committerAnoop C S <anoopcs@samba.org>
Fri, 16 Aug 2024 08:34:33 +0000 (08:34 +0000)
winbind_ctdb_updatekeytab.sh assumes the presence `onnode` utility to
execute `net ads` command on all nodes in the cluster. But `onnode`
is only built when configured with clustering support. Therefore perform
the script installation only with ctdb configuration. Also fix the
installation path to /usr/share/ctdb/scripts.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15689
Signed-off-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
source3/script/wscript_build

index 2b0643b0876d5e49ea907ae34c7712e31e81c872..bc451497298494c8d83df718f13719bd4a9af10c 100644 (file)
@@ -6,7 +6,9 @@ bld.INSTALL_FILES('${BINDIR}',
                  'smbtar',
                   chmod=MODE_755, flat=True)
 bld.INSTALL_FILES('${BINDIR}', 'samba-log-parser', chmod=MODE_755, flat=True)
-bld.INSTALL_FILES('${DATADIR}', 'winbind_ctdb_updatekeytab.sh', chmod=MODE_755, flat=True)
+if conf.env.with_ctdb:
+    bld.INSTALL_FILES(bld.env.CTDB_DATADIR+"/scripts",
+                      'winbind_ctdb_updatekeytab.sh', chmod=MODE_755, flat=True)
 
 # Callout scripts for use in selftest environment
 bld.SAMBA_SCRIPT('smbaddshare', pattern='smbaddshare', installdir='.')