libnet: Fix Coverity ID 1634803 Dereference after null check

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Nov 14 18:29:46 UTC 2024 on atb-devel-224

diff --git a/source4/libnet/libnet_site.c b/source4/libnet/libnet_site.c
index 369db586fb9cd0948b166a39b578e8c293ceaeee..9ee51f3ee86370ff8675b6835e8d4b64de9a7687 100644 (file)
--- a/source4/libnet/libnet_site.c
+++ b/source4/libnet/libnet_site.c
@@ -85,7 +85,7 @@ NTSTATUS libnet_FindSite(TALLOC_CTX *ctx, struct libnet_context *lctx, struct li
 
                map_netlogon_samlogon_response(resp);
 
-               if ((nt5ex->client_site != NULL) ||
+               if ((nt5ex->client_site != NULL) &&
                    (nt5ex->client_site[0] != '\0'))
                {
                        site_name_str = talloc_strdup(tmp_ctx,