Scrollspy selecting the last element when at the bottom of the page (fixes #17739)

diff --git a/js/src/scrollspy.js b/js/src/scrollspy.js
index 98582f91820e0cdc350c389ae1f698339cb76310..9b39acd3628ac613864c1427fe31273c60596c96 100644 (file)
--- a/js/src/scrollspy.js
+++ b/js/src/scrollspy.js
@@ -196,12 +196,17 @@ const ScrollSpy = (($) => {
       )
     }
 
+    _getOffsetHeight() {
+      return this._scrollElement === window ?
+          window.innerHeight : this._scrollElement.offsetHeight
+    }
+
     _process() {
       const scrollTop    = this._getScrollTop() + this._config.offset
       const scrollHeight = this._getScrollHeight()
       const maxScroll    = this._config.offset
         + scrollHeight
-        - this._scrollElement.offsetHeight
+        - this._getOffsetHeight()
 
       if (this._scrollHeight !== scrollHeight) {
         this.refresh()
@@ -213,6 +218,7 @@ const ScrollSpy = (($) => {
         if (this._activeTarget !== target) {
           this._activate(target)
         }
+        return
       }
 
       if (this._activeTarget && scrollTop < this._offsets[0]) {