]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: staging: rkisp1: rsz: supported formats are the isp's src formats, not sink...
authorDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Thu, 18 Jun 2020 11:35:15 +0000 (13:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Aug 2020 06:26:31 +0000 (08:26 +0200)
[ Upstream commit 7b8ce1f2763b9351a4cb04b802835470e76770a5 ]

The rkisp1_resizer's enum callback 'rkisp1_rsz_enum_mbus_code'
calls the enum callback of the 'rkisp1_isp' on it's video sink pad.
This is a bug, the resizer should support the same formats
supported by the 'rkisp1_isp' on the source pad (not the sink pad).

Fixes: 56e3b29f9f6b "media: staging: rkisp1: add streaming paths"
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/media/rkisp1/rkisp1-resizer.c

index d049374413dcf47a3b58c5db77cd4c466c48dc42..d64c064bdb1d2007252d735e0ae258299dcc69f9 100644 (file)
@@ -437,8 +437,8 @@ static int rkisp1_rsz_enum_mbus_code(struct v4l2_subdev *sd,
        u32 pad = code->pad;
        int ret;
 
-       /* supported mbus codes are the same in isp sink pad */
-       code->pad = RKISP1_ISP_PAD_SINK_VIDEO;
+       /* supported mbus codes are the same in isp video src pad */
+       code->pad = RKISP1_ISP_PAD_SOURCE_VIDEO;
        ret = v4l2_subdev_call(&rsz->rkisp1->isp.sd, pad, enum_mbus_code,
                               &dummy_cfg, code);