gh-76760: test that `uuid.uuid1()` sets the version field (#139033)

diff --git a/Lib/test/test_uuid.py b/Lib/test/test_uuid.py
index edce504fc4ba65a273be2be254e1497b9a9d516b..33045a78721aac955338b4db23fdd539bbc1d7da 100755 (executable)
--- a/Lib/test/test_uuid.py
+++ b/Lib/test/test_uuid.py
@@ -590,6 +590,7 @@ class BaseTestUUID:
         # dependent on the underlying platform support.  At least it cannot be
         # unknown (unless I suppose the platform is buggy).
         self.assertNotEqual(u.is_safe, self.uuid.SafeUUID.unknown)
+        self.assertEqual(u.version, 1)
 
     @contextlib.contextmanager
     def mock_generate_time_safe(self, safe_value):
@@ -612,24 +613,28 @@ class BaseTestUUID:
         with self.mock_generate_time_safe(None):
             u = self.uuid.uuid1()
             self.assertEqual(u.is_safe, self.uuid.SafeUUID.unknown)
+            self.assertEqual(u.version, 1)
 
     @unittest.skipUnless(os.name == 'posix', 'POSIX-only test')
     def test_uuid1_is_safe(self):
         with self.mock_generate_time_safe(0):
             u = self.uuid.uuid1()
             self.assertEqual(u.is_safe, self.uuid.SafeUUID.safe)
+            self.assertEqual(u.version, 1)
 
     @unittest.skipUnless(os.name == 'posix', 'POSIX-only test')
     def test_uuid1_is_unsafe(self):
         with self.mock_generate_time_safe(-1):
             u = self.uuid.uuid1()
             self.assertEqual(u.is_safe, self.uuid.SafeUUID.unsafe)
+            self.assertEqual(u.version, 1)
 
     @unittest.skipUnless(os.name == 'posix', 'POSIX-only test')
     def test_uuid1_bogus_return_value(self):
         with self.mock_generate_time_safe(3):
             u = self.uuid.uuid1()
             self.assertEqual(u.is_safe, self.uuid.SafeUUID.unknown)
+            self.assertEqual(u.version, 1)
 
     def test_uuid1_time(self):
         with mock.patch.object(self.uuid, '_generate_time_safe', None), \

diff --git a/Lib/uuid.py b/Lib/uuid.py
index 313f2fc46cb34611ac505770543aac8547985137..c0150a59d7cb9a8793ac8fe1e1310404aaea6e58 100644 (file)
--- a/Lib/uuid.py
+++ b/Lib/uuid.py
@@ -737,6 +737,7 @@ def uuid1(node=None, clock_seq=None):
             is_safe = SafeUUID(safely_generated)
         except ValueError:
             is_safe = SafeUUID.unknown
+        # The version field is assumed to be handled by _generate_time_safe().
         return UUID(bytes=uuid_time, is_safe=is_safe)
 
     global _last_timestamp