]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
powerpc/powernv: pr_warn_once on unsupported OPAL_MSG type
authorStewart Smith <stewart@linux.vnet.ibm.com>
Fri, 11 Dec 2015 01:08:23 +0000 (12:08 +1100)
committerLuis Henriques <luis.henriques@canonical.com>
Mon, 25 Jan 2016 10:43:41 +0000 (10:43 +0000)
commit 98da62b716a3b24ab8e77453c9a8a954124c18cd upstream.

When running on newer OPAL firmware that supports sending extra
OPAL_MSG types, we would print a warning on *every* message received.

This could be a problem for kernels that don't support OPAL_MSG_OCC
on machines that are running real close to thermal limits and the
OCC is throttling the chip. For a kernel that is paying attention to
the message queue, we could get these notifications quite often.

Conceivably, future message types could also come fairly often,
and printing that we didn't understand them 10,000 times provides
no further information than printing them once.

Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
arch/powerpc/platforms/powernv/opal.c

index d5e5794db9893dfb44deaa694e6a7f01c4e78b02..0fa7178d36dc46238dc5682c8b4411e41b2703b9 100644 (file)
@@ -329,7 +329,7 @@ static void opal_handle_message(void)
 
        /* Sanity check */
        if (type >= OPAL_MSG_TYPE_MAX) {
-               pr_warning("%s: Unknown message type: %u\n", __func__, type);
+               pr_warn_once("%s: Unknown message type: %u\n", __func__, type);
                return;
        }
        opal_message_do_notify(type, (void *)&msg);