]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
can: bxcan: bxcan_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_inva...
authorMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 17 Oct 2025 14:28:49 +0000 (16:28 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 20 Oct 2025 15:17:55 +0000 (17:17 +0200)
In addition to can_dropped_invalid_skb(), the helper function
can_dev_dropped_skb() checks whether the device is in listen-only mode and
discards the skb accordingly.

Replace can_dropped_invalid_skb() by can_dev_dropped_skb() to also drop
skbs in for listen-only mode.

Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Closes: https://lore.kernel.org/all/20251017-bizarre-enchanted-quokka-f3c704-mkl@pengutronix.de/
Fixes: f00647d8127b ("can: bxcan: add support for ST bxCAN controller")
Link: https://patch.msgid.link/20251017-fix-skb-drop-check-v1-1-556665793fa4@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/bxcan.c

index bfc60eb33dc3752722909c3cf6bffad29696f851..333ad42ea73bcdf2865349d4564911b9b3c77a12 100644 (file)
@@ -842,7 +842,7 @@ static netdev_tx_t bxcan_start_xmit(struct sk_buff *skb,
        u32 id;
        int i, j;
 
-       if (can_dropped_invalid_skb(ndev, skb))
+       if (can_dev_dropped_skb(ndev, skb))
                return NETDEV_TX_OK;
 
        if (bxcan_tx_busy(priv))