]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Initialize struct netr_IdentityInfo
authorAndreas Schneider <asn@samba.org>
Fri, 5 Jul 2024 11:37:30 +0000 (13:37 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 16 Jul 2024 11:41:33 +0000 (11:41 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/rpc/samr.c:3601: var_decl: Declaring variable ""identity"" without initializer.
samba-4.20.0rc2/source4/torture/rpc/samr.c:3650: uninit_use: Using uninitialized value ""identity"". Field ""identity.domain_name.length"" is uninitialized.
 3648|    }
 3649|
 3650|->  pinfo.identity_info = identity;
 3651|    logon.password = &pinfo;
 3652|"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
source4/torture/rpc/samr.c

index b7d0b2c72cfaf2b0192d8d9b29811894729a895e..36dd86f6770df380e849ac60bd89d04b93feabd5 100644 (file)
@@ -3598,7 +3598,7 @@ static bool test_SamLogon(struct torture_context *tctx,
        union netr_LogonLevel logon;
        union netr_Validation validation;
        uint8_t authoritative;
-       struct netr_IdentityInfo identity;
+       struct netr_IdentityInfo identity = {};
        struct netr_NetworkInfo ninfo;
        struct netr_PasswordInfo pinfo;
        DATA_BLOB names_blob, chal, lm_resp, nt_resp;