]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
x86/tdx: Fix the typo in TDX_ATTR_MIGRTABLE
authorXiaoyao Li <xiaoyao.li@intel.com>
Tue, 3 Mar 2026 03:03:32 +0000 (11:03 +0800)
committerDave Hansen <dave.hansen@linux.intel.com>
Wed, 4 Mar 2026 00:06:49 +0000 (16:06 -0800)
The TD scoped TDCS attributes are defined by bit positions. In the guest
side of the TDX code, the 'tdx_attributes' string array holds pretty
print names for these attributes, which are generated via macros and
defines. Today these pretty print names are only used to print the
attribute names to dmesg.

Unfortunately there is a typo in the define for the migratable bit.
Change the defines TDX_ATTR_MIGRTABLE* to TDX_ATTR_MIGRATABLE*. Update
the sole user, the tdx_attributes array, to use the fixed name.

Since these defines control the string printed to dmesg, the change is
user visible. But the risk of breakage is almost zero since it is not
exposed in any interface expected to be consumed programmatically.

Fixes: 564ea84c8c14 ("x86/tdx: Dump attributes and TD_CTLS on boot")
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Kai Huang <kai.huang@intel.com>
Acked-by: Sean Christopherson <seanjc@google.com>
Link: https://patch.msgid.link/20260303030335.766779-2-xiaoyao.li@intel.com
arch/x86/coco/tdx/debug.c
arch/x86/include/asm/shared/tdx.h

index cef847c8bb67f763cf3aa73fe5ef633e090d81e6..28990c2ab0a1433ce8c8af5b845fd2bcca0a1705 100644 (file)
@@ -17,7 +17,7 @@ static __initdata const char *tdx_attributes[] = {
        DEF_TDX_ATTR_NAME(ICSSD),
        DEF_TDX_ATTR_NAME(LASS),
        DEF_TDX_ATTR_NAME(SEPT_VE_DISABLE),
-       DEF_TDX_ATTR_NAME(MIGRTABLE),
+       DEF_TDX_ATTR_NAME(MIGRATABLE),
        DEF_TDX_ATTR_NAME(PKS),
        DEF_TDX_ATTR_NAME(KL),
        DEF_TDX_ATTR_NAME(TPA),
index 8bc074c8d7c6a1613c1822ad96aa3ca74a136659..11f3cf30b1ac8acac05857eba22bc4c967ecb76a 100644 (file)
@@ -35,8 +35,8 @@
 #define TDX_ATTR_LASS                  BIT_ULL(TDX_ATTR_LASS_BIT)
 #define TDX_ATTR_SEPT_VE_DISABLE_BIT   28
 #define TDX_ATTR_SEPT_VE_DISABLE       BIT_ULL(TDX_ATTR_SEPT_VE_DISABLE_BIT)
-#define TDX_ATTR_MIGRTABLE_BIT         29
-#define TDX_ATTR_MIGRTABLE             BIT_ULL(TDX_ATTR_MIGRTABLE_BIT)
+#define TDX_ATTR_MIGRATABLE_BIT                29
+#define TDX_ATTR_MIGRATABLE            BIT_ULL(TDX_ATTR_MIGRATABLE_BIT)
 #define TDX_ATTR_PKS_BIT               30
 #define TDX_ATTR_PKS                   BIT_ULL(TDX_ATTR_PKS_BIT)
 #define TDX_ATTR_KL_BIT                        31