]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
x86/asm/entry/32: Fix user_mode() misuses
authorAndy Lutomirski <luto@amacapital.net>
Tue, 10 Mar 2015 00:42:31 +0000 (17:42 -0700)
committerLuis Henriques <luis.henriques@canonical.com>
Mon, 30 Mar 2015 10:11:18 +0000 (11:11 +0100)
commit 394838c96013ba414a24ffe7a2a593a9154daadf upstream.

The one in do_debug() is probably harmless, but better safe than sorry.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/d67deaa9df5458363623001f252d1aee3215d014.1425948056.git.luto@amacapital.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
[ luis: backported to 3.16:
  - drop changes to do_bounds() ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
arch/x86/kernel/traps.c

index 07ab8e9733c5ae18ace7b905c6ff3d2a0499aac6..871f43ae47efbb8c0899192b7b93d06ad229951f 100644 (file)
@@ -483,7 +483,7 @@ dotraplinkage void do_debug(struct pt_regs *regs, long error_code)
         * then it's very likely the result of an icebp/int01 trap.
         * User wants a sigtrap for that.
         */
-       if (!dr6 && user_mode(regs))
+       if (!dr6 && user_mode_vm(regs))
                user_icebp = 1;
 
        /* Catch kmemcheck conditions first of all! */