]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: mana: Move current_speed debugfs file to mana_init_port()
authorErni Sri Satya Vennela <ernis@linux.microsoft.com>
Wed, 8 Apr 2026 08:12:20 +0000 (01:12 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sun, 12 Apr 2026 18:22:54 +0000 (11:22 -0700)
Move the current_speed debugfs file creation from mana_probe_port() to
mana_init_port(). The file was previously created only during initial
probe, but mana_cleanup_port_context() removes the entire vPort debugfs
directory during detach/attach cycles. Since mana_init_port() recreates
the directory on re-attach, moving current_speed here ensures it survives
these cycles.

Fixes: 75cabb46935b ("net: mana: Add support for net_shaper_ops")
Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260408081224.302308-3-ernis@linux.microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microsoft/mana/mana_en.c

index 09a53c9775455034137fb6fa63579ec42a3b721b..a9f5efc5af37f394e30e3b78b7f52b9c4a7eb9de 100644 (file)
@@ -3117,6 +3117,8 @@ static int mana_init_port(struct net_device *ndev)
        eth_hw_addr_set(ndev, apc->mac_addr);
        sprintf(vport, "vport%d", port_idx);
        apc->mana_port_debugfs = debugfs_create_dir(vport, gc->mana_pci_debugfs);
+       debugfs_create_u32("current_speed", 0400, apc->mana_port_debugfs,
+                          &apc->speed);
        return 0;
 
 reset_apc:
@@ -3393,8 +3395,6 @@ static int mana_probe_port(struct mana_context *ac, int port_idx,
 
        netif_carrier_on(ndev);
 
-       debugfs_create_u32("current_speed", 0400, apc->mana_port_debugfs, &apc->speed);
-
        return 0;
 
 free_indir: