BUG/MINOR: check: properly report errno in chk_report_conn_err()

When in 2.2, with commit c8dc20a825 ("BUG/MINOR: checks: refine which
errno values are really errors."), errno reporting was refined, an
extra check was added before calling retrieve_errno_from_socket(), and
by mistake the test on !errno got inverted so that we only call the
function to retrieve the error from the socket when errno is set!
The first test in the function detects it and returns without changing
anything, so this didn't have much effect, however when errno is not
set (certain call places purposely pass zero so that getsockopt() is
used), this wasn't called so the error wasn't reported. Apparently it
only happened when called from process_chk_conn() after an async
error was detected, so probably just cases where POLLERR is reported,
which remains infrequent.

Let's fix the direction of this flag. It can be backported if needed
but it's unlikely anyone really noticed.

diff --git a/src/check.c b/src/check.c
index 077956559ca4ec7dffa5ba9dc39d35a8bb6ef777..01c3d21329eba37e748ba9ba2ed361ba8e6f1888 100644 (file)
--- a/src/check.c
+++ b/src/check.c
@@ -812,7 +812,7 @@ void chk_report_conn_err(struct check *check, int errno_bck, int expired)
        }
 
        errno = unclean_errno(errno_bck);
-       if (conn && errno)
+       if (conn && !errno)
                retrieve_errno_from_socket(conn);
 
        TRACE_ENTER(CHK_EV_HCHK_END|CHK_EV_HCHK_ERR, check, 0, 0, (size_t[]){expired});