coverity.sh: check that coverity responds with 200

This is mostly inspired by https://github.com/pmem/pmdk/commit/7b103fd2dd54b2e5974f71fb65c81ab3713c12c5

Closes https://github.com/systemd/systemd/issues/9186.

diff --git a/tools/coverity.sh b/tools/coverity.sh
index 3e8d874728fea517438be850cf4ef6cde5f72429..561d127d1efdae4483b08d5886697f3f0878656f 100755 (executable)
--- a/tools/coverity.sh
+++ b/tools/coverity.sh
@@ -1,5 +1,10 @@
 #!/bin/env bash
 
+# The official unmodified version of the script can be found at
+# https://scan.coverity.com/scripts/travisci_build_coverity_scan.sh
+
+set -e
+
 # Declare build command
 COVERITY_SCAN_BUILD_COMMAND="ninja -C cov-build"
 
@@ -135,8 +140,12 @@ _upload()
          --form version=$SHA \
          --form description="Travis CI build" \
          $UPLOAD_URL)
+       printf "\033[33;1mThe response is\033[0m\n%s\n" "$response"
        status_code=$(echo "$response" | sed -n '$p')
-       if [ "$status_code" != "201" ]; then
+       # Coverity Scan used to respond with 201 on successfully receieving analysis results.
+       # Now for some reason it sends 200 and may change back in the foreseeable future.
+       # See https://github.com/pmem/pmdk/commit/7b103fd2dd54b2e5974f71fb65c81ab3713c12c5
+       if [ "$status_code" != "200" ]; then
          TEXT=$(echo "$response" | sed '$d')
          echo -e "\033[33;1mCoverity Scan upload failed: $TEXT.\033[0m"
          exit 1