]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
py/provision/sambadns: Add a comment about DNS types
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 1 Apr 2021 02:23:48 +0000 (15:23 +1300)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 8 Apr 2021 21:54:35 +0000 (21:54 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
python/samba/provision/sambadns.py

index 7c6ef0978cf21536483f358e0049634f1619cbc2..4ddde36b4cb6e2242b50fc4a1bce495e471dc56e 100644 (file)
@@ -75,6 +75,15 @@ def get_dnsadmins_sid(samdb, domaindn):
     return dnsadmins_sid
 
 
+# Note: these classses are not quite the same as similar looking ones
+# in ../dnsserver.py -- those ones are based on
+# dnsserver.DNS_RPC_RECORD ([MS-DNSP]2.2.2.2.5 "DNS_RPC_RECORD"),
+# these are based on dnsp.DnssrvRpcRecord ([MS-DNSP] 2.3.2.2
+# "DnsRecord").
+#
+# They are not interchangeable or mergeable. If you're talking over
+# the wire you want those other ones; these are the on-disk format.
+
 class ARecord(dnsp.DnssrvRpcRecord):
 
     def __init__(self, ip_addr, serial=1, ttl=900, rank=dnsp.DNS_RANK_ZONE):