rec: Actually test the deserialized cache content in the unit test

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

diff --git a/pdns/recursordist/test-recursorcache_cc.cc b/pdns/recursordist/test-recursorcache_cc.cc
index 3ed068b7b20a7dccfaa35febed50a74d2bdbb5be..b8789316e6a1a694f4ce985dd79f65de30bb3fa9 100644 (file)
--- a/pdns/recursordist/test-recursorcache_cc.cc
+++ b/pdns/recursordist/test-recursorcache_cc.cc
@@ -1301,7 +1301,7 @@ BOOST_AUTO_TEST_CASE(test_RecursorCacheDumpAndRestore)
   dr.d_name = DNSName("hi");
   dr.d_type = QType::AAAA;
   dr.d_ttl = 3600;
-  dr.setContent(std::make_shared<ARecordContent>(ComboAddress("1::2:3:4")));
+  dr.setContent(std::make_shared<AAAARecordContent>(ComboAddress("1::2:3:4")));
   authRecords.emplace_back(dr);
 
   std::vector<std::shared_ptr<const RRSIGRecordContent>> signatures;
@@ -1327,18 +1327,18 @@ BOOST_AUTO_TEST_CASE(test_RecursorCacheDumpAndRestore)
   const MemRecursorCache::Extra authAddress{ComboAddress{"::2"}, true};
   const time_t ttl_time = 90;
 
-  auto checker = [&] {
-    const size_t expected = 100;
+  const size_t expected = 100;
 
-    for (size_t counter = 0; counter < expected; ++counter) {
-      DNSName a = DNSName("hello ") + DNSName(std::to_string(counter));
-      BOOST_CHECK_EQUAL(DNSName(a.toString()), a);
+  for (size_t counter = 0; counter < expected; ++counter) {
+    DNSName a = DNSName("hello ") + DNSName(std::to_string(counter));
+    BOOST_CHECK_EQUAL(DNSName(a.toString()), a);
 
-      MRC.replace(now, a, QType(QType::A), rset0, signatures, authRecords, true, authZone, std::nullopt, MemRecursorCache::NOTAG, vState::Insecure, authAddress, false, ttl_time);
-    }
+    MRC.replace(now, a, QType(QType::A), rset0, signatures, authRecords, true, authZone, std::nullopt, MemRecursorCache::NOTAG, vState::Insecure, authAddress, false, ttl_time);
+  }
 
-    BOOST_CHECK_EQUAL(MRC.size(), expected);
+  BOOST_CHECK_EQUAL(MRC.size(), expected);
 
+  auto checker = [&] {
     size_t matches = 0;
 
     for (size_t counter = 0; counter < expected + 10; counter++) {