]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: microchip: mpfs-mss-top-sysreg: Fix resource leak on driver unbind
authorFelix Gu <ustc.gu@gmail.com>
Mon, 9 Mar 2026 12:16:15 +0000 (20:16 +0800)
committerConor Dooley <conor.dooley@microchip.com>
Thu, 19 Mar 2026 15:55:16 +0000 (15:55 +0000)
Use devm_mfd_add_devices() instead of mfd_add_devices() to ensure
child devices are properly removed when the driver unbinds.

Fixes: 4aac11c9a6e7 ("soc: microchip: add mfd drivers for two syscon regions on PolarFire SoC")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
drivers/soc/microchip/mpfs-mss-top-sysreg.c

index b2244e44ff0fa7b30f3215751fa211dddfbf1e90..b0f42b8dd3ed6349c10d292d41e1c8aaec86311d 100644 (file)
@@ -16,8 +16,10 @@ static int mpfs_mss_top_sysreg_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        int ret;
 
-       ret = mfd_add_devices(dev, PLATFORM_DEVID_NONE, mpfs_mss_top_sysreg_devs,
-                             ARRAY_SIZE(mpfs_mss_top_sysreg_devs) , NULL, 0, NULL);
+       ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
+                                  mpfs_mss_top_sysreg_devs,
+                                  ARRAY_SIZE(mpfs_mss_top_sysreg_devs), NULL,
+                                  0, NULL);
        if (ret)
                return ret;