net: sched: delete duplicate cleanup of backlog and qlen

[ Upstream commit c19d893fbf3f2f8fa864ae39652c7fee939edde2 ]

qdisc_reset() is clearing qdisc->q.qlen and qdisc->qstats.backlog
_after_ calling qdisc->ops->reset. There is no need to clear them
again in the specific reset function.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20220824005231.345727-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Stable-dep-of: 2a3fc78210b9 ("net: sched: sfb: fix null pointer access issue when sfb_init() fails")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index ec693fe7c55398bb44977d6d2e54b2d65b97087b..f2958fb5ae08bb19cbb821632ecdd1301ea7f322 100644 (file)
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -1137,7 +1137,6 @@ static inline void __qdisc_reset_queue(struct qdisc_skb_head *qh)
 static inline void qdisc_reset_queue(struct Qdisc *sch)
 {
        __qdisc_reset_queue(&sch->q);
-       sch->qstats.backlog = 0;
 }
 
 static inline struct Qdisc *qdisc_replace(struct Qdisc *sch, struct Qdisc *new,

diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
index 4c8e994cf0a536a93e56a200102d49294005f291..816fd0d7ba38ad5c6cd791b32eef6af4bfb1b30c 100644 (file)
--- a/net/sched/sch_atm.c
+++ b/net/sched/sch_atm.c
@@ -577,7 +577,6 @@ static void atm_tc_reset(struct Qdisc *sch)
        pr_debug("atm_tc_reset(sch %p,[qdisc %p])\n", sch, p);
        list_for_each_entry(flow, &p->flows, list)
                qdisc_reset(flow->q);
-       sch->q.qlen = 0;
 }
 
 static void atm_tc_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
index 91a0dc463c4826ebf721e76b603a9a2b7989c5b3..ba99ce05cd5274e1f9e2396a1382a48e5527bce2 100644 (file)
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -975,7 +975,6 @@ cbq_reset(struct Qdisc *sch)
                        cl->cpriority = cl->priority;
                }
        }
-       sch->q.qlen = 0;
 }
 
 

diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
index 2adbd945bf15aee182bc1505ec54b9695d104d52..25d2daaa81227478f3f91c57c26ea8185c686462 100644 (file)
--- a/net/sched/sch_choke.c
+++ b/net/sched/sch_choke.c
@@ -315,8 +315,6 @@ static void choke_reset(struct Qdisc *sch)
                rtnl_qdisc_drop(skb, sch);
        }
 
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
        if (q->tab)
                memset(q->tab, 0, (q->tab_mask + 1) * sizeof(struct sk_buff *));
        q->head = q->tail = 0;

diff --git a/net/sched/sch_drr.c b/net/sched/sch_drr.c
index 18e4f7a0b291242731610723f38b1f1c7858beb0..4e5b1cf11b858dd5e9ef68ac4d85f7a776ad023e 100644 (file)
--- a/net/sched/sch_drr.c
+++ b/net/sched/sch_drr.c
@@ -441,8 +441,6 @@ static void drr_reset_qdisc(struct Qdisc *sch)
                        qdisc_reset(cl->qdisc);
                }
        }
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void drr_destroy_qdisc(struct Qdisc *sch)

diff --git a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c
index 4c100d10526996c8d26adc22666e0f5f4ecad148..7da6dc38a3828293b8128929ad1e405ed6c096d8 100644 (file)
--- a/net/sched/sch_dsmark.c
+++ b/net/sched/sch_dsmark.c
@@ -409,8 +409,6 @@ static void dsmark_reset(struct Qdisc *sch)
        pr_debug("%s(sch %p,[qdisc %p])\n", __func__, sch, p);
        if (p->q)
                qdisc_reset(p->q);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void dsmark_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c
index c48f91075b5c60ee4fe9e10186c913baf5894a69..d96103b0e2bf516bb668aa4037cbf85a7c8f9e30 100644 (file)
--- a/net/sched/sch_etf.c
+++ b/net/sched/sch_etf.c
@@ -445,9 +445,6 @@ static void etf_reset(struct Qdisc *sch)
        timesortedlist_clear(sch);
        __qdisc_reset_queue(&sch->q);
 
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
-
        q->last = 0;
 }
 

diff --git a/net/sched/sch_ets.c b/net/sched/sch_ets.c
index d73393493553389ac77fa7d16c500ad6c7f49404..8de4365886e84950e7a521d0649df94075471845 100644 (file)
--- a/net/sched/sch_ets.c
+++ b/net/sched/sch_ets.c
@@ -727,8 +727,6 @@ static void ets_qdisc_reset(struct Qdisc *sch)
        }
        for (band = 0; band < q->nbands; band++)
                qdisc_reset(q->classes[band].qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void ets_qdisc_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
index 839e1235db053b7a8606c67484db861c4605b61e..23a042adb74d8d80771a87a032d37cc0aff76aa5 100644 (file)
--- a/net/sched/sch_fq_codel.c
+++ b/net/sched/sch_fq_codel.c
@@ -347,8 +347,6 @@ static void fq_codel_reset(struct Qdisc *sch)
                codel_vars_init(&flow->cvars);
        }
        memset(q->backlogs, 0, q->flows_cnt * sizeof(u32));
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
        q->memory_usage = 0;
 }
 

diff --git a/net/sched/sch_fq_pie.c b/net/sched/sch_fq_pie.c
index d6aba6edd16e5eab120a57c316fcb06a5d5f3442..35c35465226bdb432556cbe79424a6045d74c089 100644 (file)
--- a/net/sched/sch_fq_pie.c
+++ b/net/sched/sch_fq_pie.c
@@ -521,9 +521,6 @@ static void fq_pie_reset(struct Qdisc *sch)
                INIT_LIST_HEAD(&flow->flowchain);
                pie_vars_init(&flow->vars);
        }
-
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
 }
 
 static void fq_pie_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index d3979a6000e7d2edecef5cb7e50a10b26eb2736f..03efc40e42fc44143bc96b5acc5cf2fb7df902b5 100644 (file)
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -1484,8 +1484,6 @@ hfsc_reset_qdisc(struct Qdisc *sch)
        }
        q->eligible = RB_ROOT;
        qdisc_watchdog_cancel(&q->watchdog);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void

diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 23a9d6242429f1f9fadd047602108daffe3708ea..cb5872d22ecf49dd3c2d0ff4b9c553228b6912f2 100644 (file)
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -1008,8 +1008,6 @@ static void htb_reset(struct Qdisc *sch)
        }
        qdisc_watchdog_cancel(&q->watchdog);
        __qdisc_reset_queue(&q->direct_queue);
-       sch->q.qlen = 0;
-       sch->qstats.backlog = 0;
        memset(q->hlevel, 0, sizeof(q->hlevel));
        memset(q->row_mask, 0, sizeof(q->row_mask));
 }

diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c
index cd8ab90c4765d48b7b0f65ff1d68a43a9b2b7ace..f28050c7f12d6ffe161a025b2b1fd87428384fb8 100644 (file)
--- a/net/sched/sch_multiq.c
+++ b/net/sched/sch_multiq.c
@@ -152,7 +152,6 @@ multiq_reset(struct Qdisc *sch)
 
        for (band = 0; band < q->bands; band++)
                qdisc_reset(q->queues[band]);
-       sch->q.qlen = 0;
        q->curband = 0;
 }
 

diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
index 3b8d7197c06bff3f346b1616db0210d6e8c5e704..c03a11dd990f40de7a0e31d39e48c4825a9d55f3 100644 (file)
--- a/net/sched/sch_prio.c
+++ b/net/sched/sch_prio.c
@@ -135,8 +135,6 @@ prio_reset(struct Qdisc *sch)
 
        for (prio = 0; prio < q->bands; prio++)
                qdisc_reset(q->queues[prio]);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static int prio_offload(struct Qdisc *sch, struct tc_prio_qopt *qopt)

diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index d4ce58c90f9fbab1a4f35e08213b11f87cce92af..13246a9dc5c1c0f1f74dbf46cc25c356c9b99366 100644 (file)
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -1458,8 +1458,6 @@ static void qfq_reset_qdisc(struct Qdisc *sch)
                        qdisc_reset(cl->qdisc);
                }
        }
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void qfq_destroy_qdisc(struct Qdisc *sch)

diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c
index 40adf1f07a82dfdb8f704eecfa9a14f000213a91..f1e013e3f04a985eeb48165edf2ff41878accdf5 100644 (file)
--- a/net/sched/sch_red.c
+++ b/net/sched/sch_red.c
@@ -176,8 +176,6 @@ static void red_reset(struct Qdisc *sch)
        struct red_sched_data *q = qdisc_priv(sch);
 
        qdisc_reset(q->qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
        red_restart(&q->vars);
 }
 

diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c
index 2829455211f8c50fcc14a9b3902035481e43ae78..1be8d04d69dc8a9b3bbe53d5f819fb222d6d6b62 100644 (file)
--- a/net/sched/sch_sfb.c
+++ b/net/sched/sch_sfb.c
@@ -456,8 +456,6 @@ static void sfb_reset(struct Qdisc *sch)
        struct sfb_sched_data *q = qdisc_priv(sch);
 
        qdisc_reset(q->qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
        q->slot = 0;
        q->double_buffering = false;
        sfb_zero_all_buckets(q);

diff --git a/net/sched/sch_skbprio.c b/net/sched/sch_skbprio.c
index 7a5e4c454715617cb57c6db7de7fdaa9e6886d40..df72fb83d9c7d88bb93d08c9a7453abe8a055eb0 100644 (file)
--- a/net/sched/sch_skbprio.c
+++ b/net/sched/sch_skbprio.c
@@ -213,9 +213,6 @@ static void skbprio_reset(struct Qdisc *sch)
        struct skbprio_sched_data *q = qdisc_priv(sch);
        int prio;
 
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
-
        for (prio = 0; prio < SKBPRIO_MAX_PRIORITY; prio++)
                __skb_queue_purge(&q->qdiscs[prio]);
 

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 86675a79da1e4ac1ede8934c93e2021639018e52..5bffc37022e0b53406277813d2cee24d3a87783d 100644 (file)
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1638,8 +1638,6 @@ static void taprio_reset(struct Qdisc *sch)
                        if (q->qdiscs[i])
                                qdisc_reset(q->qdiscs[i]);
        }
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
 }
 
 static void taprio_destroy(struct Qdisc *sch)

diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
index 36079fdde2cb5018fbd8999e449153bd21f74180..e031c1a41ea6b87524bb677b5613305c605ad660 100644 (file)
--- a/net/sched/sch_tbf.c
+++ b/net/sched/sch_tbf.c
@@ -330,8 +330,6 @@ static void tbf_reset(struct Qdisc *sch)
        struct tbf_sched_data *q = qdisc_priv(sch);
 
        qdisc_reset(q->qdisc);
-       sch->qstats.backlog = 0;
-       sch->q.qlen = 0;
        q->t_c = ktime_get_ns();
        q->tokens = q->buffer;
        q->ptokens = q->mtu;

diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c
index 6af6b95bdb6723a3d600c1defae08fd897c7a308..79aaab51cbf5c8357f282d6d4d9ba464e83e7f30 100644 (file)
--- a/net/sched/sch_teql.c
+++ b/net/sched/sch_teql.c
@@ -124,7 +124,6 @@ teql_reset(struct Qdisc *sch)
        struct teql_sched_data *dat = qdisc_priv(sch);
 
        skb_queue_purge(&dat->q);
-       sch->q.qlen = 0;
 }
 
 static void