gh-129813: Document that PyBytesWriter_GetData() cannot fail (#145900)

Document that PyBytesWriter_GetData() and PyBytesWriter_GetSize()
getter functions cannot fail

diff --git a/Doc/c-api/bytes.rst b/Doc/c-api/bytes.rst
index 82c2557368371fd0ec7d2af6bd2d810c0f0a9b6e..b3cd26a8504715479736bff04876d83e6d72f4fc 100644 (file)
--- a/Doc/c-api/bytes.rst
+++ b/Doc/c-api/bytes.rst
@@ -371,6 +371,8 @@ Getters
 
    Get the writer size.
 
+   The function cannot fail.
+
 .. c:function:: void* PyBytesWriter_GetData(PyBytesWriter *writer)
 
    Get the writer data: start of the internal buffer.
@@ -378,6 +380,8 @@ Getters
    The pointer is valid until :c:func:`PyBytesWriter_Finish` or
    :c:func:`PyBytesWriter_Discard` is called on *writer*.
 
+   The function cannot fail.
+
 
 Low-level API
 ^^^^^^^^^^^^^

diff --git a/Modules/binascii.c b/Modules/binascii.c
index 3f3695d50f2754b23f92f410db08203fe91bd192..c076b12fb149b21a460adf969b11f0ad58993f78 100644 (file)
--- a/Modules/binascii.c
+++ b/Modules/binascii.c
@@ -923,9 +923,6 @@ binascii_a2b_ascii85_impl(PyObject *module, Py_buffer *data, int foldspaces,
         return NULL;
     }
     unsigned char *bin_data = PyBytesWriter_GetData(writer);
-    if (bin_data == NULL) {
-        goto error;
-    }
 
     uint32_t leftchar = 0;
     int group_pos = 0;