]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: intel_hdmi: Fix off-by-one error in __hdmi_lpe_audio_probe()
authorThorsten Blum <thorsten.blum@linux.dev>
Tue, 5 Aug 2025 23:41:53 +0000 (01:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 14:39:33 +0000 (16:39 +0200)
commit 8cbe564974248ee980562be02f2b1912769562c7 upstream.

In __hdmi_lpe_audio_probe(), strscpy() is incorrectly called with the
length of the source string (excluding the NUL terminator) rather than
the size of the destination buffer. This results in one character less
being copied from 'card->shortname' to 'pcm->name'.

Use the destination buffer size instead to ensure the card name is
copied correctly.

Cc: stable@vger.kernel.org
Fixes: 75b1a8f9d62e ("ALSA: Convert strlcpy to strscpy when return value is unused")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250805234156.60294-1-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/x86/intel_hdmi_audio.c

index fe5cb41390883c4bc5a67f89befb92c3a055e3e6..9df143b5deea8c425279735e94abf9528b4b3b66 100644 (file)
@@ -1768,7 +1768,7 @@ static int __hdmi_lpe_audio_probe(struct platform_device *pdev)
                /* setup private data which can be retrieved when required */
                pcm->private_data = ctx;
                pcm->info_flags = 0;
-               strscpy(pcm->name, card->shortname, strlen(card->shortname));
+               strscpy(pcm->name, card->shortname, sizeof(pcm->name));
                /* setup the ops for playback */
                snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);