]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nvmet: replace use of system_wq with system_percpu_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Mon, 23 Feb 2026 10:23:27 +0000 (11:23 +0100)
committerKeith Busch <kbusch@kernel.org>
Fri, 27 Mar 2026 14:35:05 +0000 (07:35 -0700)
This patch continues the effort to refactor workqueue APIs, which has begun
with the changes introducing new workqueues and a new alloc_workqueue flag:

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The point of the refactoring is to eventually alter the default behavior of
workqueues to become unbound by default so that their workload placement is
optimized by the scheduler.

Before that to happen, workqueue users must be converted to the better named
new workqueues with no intended behaviour changes:

   system_wq -> system_percpu_wq
   system_unbound_wq -> system_dfl_wq

This way the old obsolete workqueues (system_wq, system_unbound_wq) can be
removed in the future.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
Suggested-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/admin-cmd.c
drivers/nvme/target/fabrics-cmd-auth.c

index c0d38480bb62ed7bc7547719641d9f40b1b8552b..3794ef25855693e18ca9b33172445b12dd0dfaa4 100644 (file)
@@ -1605,7 +1605,7 @@ void nvmet_execute_keep_alive(struct nvmet_req *req)
 
        pr_debug("ctrl %d update keep-alive timer for %d secs\n",
                ctrl->cntlid, ctrl->kato);
-       mod_delayed_work(system_wq, &ctrl->ka_work, ctrl->kato * HZ);
+       mod_delayed_work(system_percpu_wq, &ctrl->ka_work, ctrl->kato * HZ);
 out:
        nvmet_req_complete(req, status);
 }
index 35f411fad8f9ed43f3db7de8921d72a8a92a7aca..b9ab80c7a6941826c40fe33a9c5f95f17f119deb 100644 (file)
@@ -390,7 +390,7 @@ done:
            req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) {
                unsigned long auth_expire_secs = ctrl->kato ? ctrl->kato : 120;
 
-               mod_delayed_work(system_wq, &req->sq->auth_expired_work,
+               mod_delayed_work(system_percpu_wq, &req->sq->auth_expired_work,
                                 auth_expire_secs * HZ);
                goto complete;
        }