]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
eth: sp7021: drop free_netdev() from spl2sw_init_netdev()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 9 Nov 2022 15:01:16 +0000 (15:01 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Nov 2022 09:04:04 +0000 (10:04 +0100)
[ Upstream commit de91b3197d15172407608b2c357aab7ac1451e2b ]

It's not necessary to free netdev allocated with devm_alloc_etherdev()
and using free_netdev() leads to double free.

Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20221109150116.2988194-1-weiyongjun@huaweicloud.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/sunplus/spl2sw_driver.c

index 61d1d07dc07044803b8225978b54fe635341a367..d6f1fef4ff3af55db2bd64c72f5a1809f934d5cc 100644 (file)
@@ -286,7 +286,6 @@ static u32 spl2sw_init_netdev(struct platform_device *pdev, u8 *mac_addr,
        if (ret) {
                dev_err(&pdev->dev, "Failed to register net device \"%s\"!\n",
                        ndev->name);
-               free_netdev(ndev);
                *r_ndev = NULL;
                return ret;
        }