]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
btrfs: change BUG_ON to assertion when checking for delayed_node root
authorDavid Sterba <dsterba@suse.com>
Sat, 20 Jan 2024 01:26:32 +0000 (02:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Sep 2024 11:17:37 +0000 (13:17 +0200)
[ Upstream commit be73f4448b607e6b7ce41cd8ef2214fdf6e7986f ]

The pointer to root is initialized in btrfs_init_delayed_node(), no need
to check for it again. Change the BUG_ON to assertion.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/delayed-inode.c

index cdfc791b3c405bf0aae9bd631dcd34f8cc82e4bd..e2afaa70ae5e5b7b65d2f1a67a91ed9547061e63 100644 (file)
@@ -986,7 +986,7 @@ static void btrfs_release_delayed_inode(struct btrfs_delayed_node *delayed_node)
 
        if (delayed_node &&
            test_bit(BTRFS_DELAYED_NODE_INODE_DIRTY, &delayed_node->flags)) {
-               BUG_ON(!delayed_node->root);
+               ASSERT(delayed_node->root);
                clear_bit(BTRFS_DELAYED_NODE_INODE_DIRTY, &delayed_node->flags);
                delayed_node->count--;