]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-47038: Rewrite missed asyncio.wait_for test to use IsolatedAnsyncioTestCase ...
authorAndrew Svetlov <andrew.svetlov@gmail.com>
Wed, 16 Mar 2022 23:20:29 +0000 (01:20 +0200)
committerGitHub <noreply@github.com>
Wed, 16 Mar 2022 23:20:29 +0000 (01:20 +0200)
Lib/test/test_asyncio/test_tasks.py
Lib/test/test_asyncio/test_waitfor.py

index 44ec8425b7f801c0795d01f95bc1c3bd6bebb8ed..141c019dcb9cc01b7911b66e78930d34e075ac6e 100644 (file)
@@ -1990,32 +1990,6 @@ class BaseTaskTests:
                           'test_task_source_traceback'))
         self.loop.run_until_complete(task)
 
-    def _test_cancel_wait_for(self, timeout):
-        loop = asyncio.new_event_loop()
-        self.addCleanup(loop.close)
-
-        async def blocking_coroutine():
-            fut = self.new_future(loop)
-            # Block: fut result is never set
-            await fut
-
-        task = loop.create_task(blocking_coroutine())
-
-        wait = loop.create_task(asyncio.wait_for(task, timeout))
-        loop.call_soon(wait.cancel)
-
-        self.assertRaises(asyncio.CancelledError,
-                          loop.run_until_complete, wait)
-
-        # Python issue #23219: cancelling the wait must also cancel the task
-        self.assertTrue(task.cancelled())
-
-    def test_cancel_blocking_wait_for(self):
-        self._test_cancel_wait_for(None)
-
-    def test_cancel_wait_for(self):
-        self._test_cancel_wait_for(60.0)
-
     def test_cancel_gather_1(self):
         """Ensure that a gathering future refuses to be cancelled once all
         children are done"""
index b00815e153110df70cb0bafdca315d977ffebf54..874aabf9bd715e286d19cc22b3c4551bf439bfec 100644 (file)
@@ -264,6 +264,30 @@ class AsyncioWaitForTest(unittest.IsolatedAsyncioTestCase):
 
         self.assertEqual(await inner_task, 42)
 
+    async def _test_cancel_wait_for(self, timeout):
+        loop = asyncio.get_running_loop()
+
+        async def blocking_coroutine():
+            fut = loop.create_future()
+            # Block: fut result is never set
+            await fut
+
+        task = asyncio.create_task(blocking_coroutine())
+
+        wait = asyncio.create_task(asyncio.wait_for(task, timeout))
+        loop.call_soon(wait.cancel)
+
+        with self.assertRaises(asyncio.CancelledError):
+            await wait
+
+        # Python issue #23219: cancelling the wait must also cancel the task
+        self.assertTrue(task.cancelled())
+
+    async def test_cancel_blocking_wait_for(self):
+        await self._test_cancel_wait_for(None)
+
+    async def test_cancel_wait_for(self):
+        await self._test_cancel_wait_for(60.0)
 
 
 if __name__ == '__main__':