drm/client: Remove drm_client_framebuffer_delete()

Release client buffers with drm_client_buffer_delete() instead of
drm_client_framebuffer_delete(). The latter is just a tiny wrapper
around the former.

Move the test for !buffer into drm_client_buffer_delete(), although
all callers appear to always have a valid pointer.

v2:
- test for !buffer before deref-ing pointer (Jocelyn, Dan)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Tested-by: Francesco Valla <francesco@valla.it>
Link: https://patch.msgid.link/20251027121042.143588-6-tzimmermann@suse.de

diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/clients/drm_log.c
index 24b08fdcb57acbdacd421d7a99f00d1d8d6a506f..c2ddc57b538ed85011c9720697147b42b5fee7f5 100644 (file)
--- a/drivers/gpu/drm/clients/drm_log.c
+++ b/drivers/gpu/drm/clients/drm_log.c
@@ -272,7 +272,7 @@ static void drm_log_init_client(struct drm_log *dlog)
 
 err_failed_commit:
        for (i = 0; i < n_modeset; i++)
-               drm_client_framebuffer_delete(dlog->scanout[i].buffer);
+               drm_client_buffer_delete(dlog->scanout[i].buffer);
 
 err_nomodeset:
        kfree(dlog->scanout);
@@ -286,7 +286,7 @@ static void drm_log_free_scanout(struct drm_client_dev *client)
 
        if (dlog->n_scanout) {
                for (i = 0; i < dlog->n_scanout; i++)
-                       drm_client_framebuffer_delete(dlog->scanout[i].buffer);
+                       drm_client_buffer_delete(dlog->scanout[i].buffer);
                dlog->n_scanout = 0;
                kfree(dlog->scanout);
                dlog->scanout = NULL;

diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index 0aa56c4b912b0eef513aa67580d9b18fb67d559b..b4e37bb2041bafad745ebcf65a2922c5a21d1626 100644 (file)
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -177,11 +177,19 @@ void drm_client_release(struct drm_client_dev *client)
 }
 EXPORT_SYMBOL(drm_client_release);
 
-static void drm_client_buffer_delete(struct drm_client_buffer *buffer)
+/**
+ * drm_client_buffer_delete - Delete a client buffer
+ * @buffer: DRM client buffer
+ */
+void drm_client_buffer_delete(struct drm_client_buffer *buffer)
 {
-       struct drm_gem_object *gem = buffer->fb->obj[0];
+       struct drm_gem_object *gem;
        int ret;
 
+       if (!buffer)
+               return;
+
+       gem = buffer->fb->obj[0];
        drm_gem_vunmap(gem, &buffer->map);
 
        ret = drm_mode_rmfb(buffer->client->dev, buffer->fb->base.id, buffer->client->file);
@@ -193,6 +201,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer)
 
        kfree(buffer);
 }
+EXPORT_SYMBOL(drm_client_buffer_delete);
 
 static struct drm_client_buffer *
 drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height,
@@ -376,7 +385,7 @@ EXPORT_SYMBOL(drm_client_buffer_vunmap);
  *
  * This function creates a &drm_client_buffer which consists of a
  * &drm_framebuffer backed by a dumb buffer.
- * Call drm_client_framebuffer_delete() to free the buffer.
+ * Call drm_client_buffer_delete() to free the buffer.
  *
  * Returns:
  * Pointer to a client buffer or an error pointer on failure.
@@ -420,19 +429,6 @@ err_drm_mode_destroy_dumb:
 }
 EXPORT_SYMBOL(drm_client_framebuffer_create);
 
-/**
- * drm_client_framebuffer_delete - Delete a client framebuffer
- * @buffer: DRM client buffer (can be NULL)
- */
-void drm_client_framebuffer_delete(struct drm_client_buffer *buffer)
-{
-       if (!buffer)
-               return;
-
-       drm_client_buffer_delete(buffer);
-}
-EXPORT_SYMBOL(drm_client_framebuffer_delete);
-
 /**
  * drm_client_framebuffer_flush - Manually flush client framebuffer
  * @buffer: DRM client buffer (can be NULL)

diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
index c6196293e4240db579f45d2720fab20fcd96f981..6216de1446c16693218ee44cf45e49c7fa5f7e95 100644 (file)
--- a/drivers/gpu/drm/drm_fbdev_dma.c
+++ b/drivers/gpu/drm/drm_fbdev_dma.c
@@ -55,7 +55,7 @@ static void drm_fbdev_dma_fb_destroy(struct fb_info *info)
        drm_fb_helper_fini(fb_helper);
 
        drm_client_buffer_vunmap(fb_helper->buffer);
-       drm_client_framebuffer_delete(fb_helper->buffer);
+       drm_client_buffer_delete(fb_helper->buffer);
        drm_client_release(&fb_helper->client);
 }
 
@@ -88,7 +88,7 @@ static void drm_fbdev_dma_shadowed_fb_destroy(struct fb_info *info)
        vfree(shadow);
 
        drm_client_buffer_vunmap(fb_helper->buffer);
-       drm_client_framebuffer_delete(fb_helper->buffer);
+       drm_client_buffer_delete(fb_helper->buffer);
        drm_client_release(&fb_helper->client);
 }
 
@@ -324,7 +324,7 @@ err_drm_client_buffer_vunmap:
        fb_helper->buffer = NULL;
        drm_client_buffer_vunmap(buffer);
 err_drm_client_buffer_delete:
-       drm_client_framebuffer_delete(buffer);
+       drm_client_buffer_delete(buffer);
        return ret;
 }
 EXPORT_SYMBOL(drm_fbdev_dma_driver_fbdev_probe);

diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c b/drivers/gpu/drm/drm_fbdev_shmem.c
index 51573058df6f878b5ce100a2ab17d32db802b5e6..520c2218e5dc8ec0d4b6271fcde473f5e5943e5f 100644 (file)
--- a/drivers/gpu/drm/drm_fbdev_shmem.c
+++ b/drivers/gpu/drm/drm_fbdev_shmem.c
@@ -63,7 +63,7 @@ static void drm_fbdev_shmem_fb_destroy(struct fb_info *info)
        drm_fb_helper_fini(fb_helper);
 
        drm_client_buffer_vunmap(fb_helper->buffer);
-       drm_client_framebuffer_delete(fb_helper->buffer);
+       drm_client_buffer_delete(fb_helper->buffer);
        drm_client_release(&fb_helper->client);
 }
 
@@ -204,7 +204,7 @@ err_drm_client_buffer_vunmap:
        fb_helper->buffer = NULL;
        drm_client_buffer_vunmap(buffer);
 err_drm_client_buffer_delete:
-       drm_client_framebuffer_delete(buffer);
+       drm_client_buffer_delete(buffer);
        return ret;
 }
 EXPORT_SYMBOL(drm_fbdev_shmem_driver_fbdev_probe);

diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
index ccf460fbc1f0ce1105fbb3cb82b6dc11188e5d65..7f7c88461228a07742e1375f4dc412d6744543ca 100644 (file)
--- a/drivers/gpu/drm/drm_fbdev_ttm.c
+++ b/drivers/gpu/drm/drm_fbdev_ttm.c
@@ -50,7 +50,7 @@ static void drm_fbdev_ttm_fb_destroy(struct fb_info *info)
        fb_deferred_io_cleanup(info);
        drm_fb_helper_fini(fb_helper);
        vfree(shadow);
-       drm_client_framebuffer_delete(fb_helper->buffer);
+       drm_client_buffer_delete(fb_helper->buffer);
 
        drm_client_release(&fb_helper->client);
 }
@@ -200,7 +200,7 @@ int drm_fbdev_ttm_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
        screen_buffer = vzalloc(screen_size);
        if (!screen_buffer) {
                ret = -ENOMEM;
-               goto err_drm_client_framebuffer_delete;
+               goto err_drm_client_buffer_delete;
        }
 
        info = drm_fb_helper_alloc_info(fb_helper);
@@ -233,10 +233,10 @@ err_drm_fb_helper_release_info:
        drm_fb_helper_release_info(fb_helper);
 err_vfree:
        vfree(screen_buffer);
-err_drm_client_framebuffer_delete:
+err_drm_client_buffer_delete:
        fb_helper->fb = NULL;
        fb_helper->buffer = NULL;
-       drm_client_framebuffer_delete(buffer);
+       drm_client_buffer_delete(buffer);
        return ret;
 }
 EXPORT_SYMBOL(drm_fbdev_ttm_driver_fbdev_probe);

diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
index b01fc2a21f0994a693c40d3f89a50127fc4bba3c..ffc4013b2e185038f98d7d0c94751dc56ccd9376 100644 (file)
--- a/include/drm/drm_client.h
+++ b/include/drm/drm_client.h
@@ -195,7 +195,7 @@ struct drm_client_buffer {
 
 struct drm_client_buffer *
 drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format);
-void drm_client_framebuffer_delete(struct drm_client_buffer *buffer);
+void drm_client_buffer_delete(struct drm_client_buffer *buffer);
 int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect);
 int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
                                 struct iosys_map *map_copy);