]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rcu-tasks: Remove unnecessary smp_store_release() in cblist_init_generic()
authorZqiang <qiang.zhang@linux.dev>
Mon, 5 Jan 2026 01:19:51 +0000 (09:19 +0800)
committerJoel Fernandes <joelagnelf@nvidia.com>
Mon, 30 Mar 2026 19:48:14 +0000 (15:48 -0400)
The cblist_init_generic() is executed during the CPU early boot
phase due to commit:30ef09635b9e ("rcu-tasks: Initialize callback
lists at rcu_init() time"), at this time, only one boot CPU is
online and the irq is disabled. this commit therefore use routine
assignment replace of smp_store_release() and WRITE_ONCE() in the
cblist_init_generic().

Signed-off-by: Zqiang <qiang.zhang@linux.dev>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
kernel/rcu/tasks.h

index 2b55e6acf3c16590ce1b75317a24c50970a5b8a5..48f0d803c8e27379878a2e6dba000c2a9d45f580 100644 (file)
@@ -291,9 +291,9 @@ static void cblist_init_generic(struct rcu_tasks *rtp)
        shift = ilog2(rcu_task_cpu_ids / lim);
        if (((rcu_task_cpu_ids - 1) >> shift) >= lim)
                shift++;
-       WRITE_ONCE(rtp->percpu_enqueue_shift, shift);
-       WRITE_ONCE(rtp->percpu_dequeue_lim, lim);
-       smp_store_release(&rtp->percpu_enqueue_lim, lim);
+       rtp->percpu_enqueue_shift = shift;
+       rtp->percpu_dequeue_lim = lim;
+       rtp->percpu_enqueue_lim = lim;
 
        pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d rcu_task_cpu_ids=%d.\n",
                        rtp->name, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim),