]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tools: ynl: don't install tests in /usr/bin/
authorJakub Kicinski <kuba@kernel.org>
Tue, 3 Mar 2026 16:35:02 +0000 (08:35 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Mar 2026 00:41:55 +0000 (16:41 -0800)
Until commit 790792ebc960 ("tools: ynl: don't install tests")
YNL selftests were installed with all the other YNL outputs.
That's no longer the case, as tests are not really production
artifacts. Let's not install them in /usr/bin at all, and
mirror kselftest format more closely:

For: make -C tools/net/ynl/tests/ install DESTDIR=tmp

tmp/usr/share/kselftest
              ├── ktap_helpers.sh
              └── ynl
                  ├── test_ynl_cli.sh
                  └── test_ynl_ethtool.sh

Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Link: https://patch.msgid.link/20260303163504.2084981-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/net/ynl/tests/Makefile

index ee4362ca286df88530459b0bc3aaf0fb44f2f9cb..5045341300e2b759b293c9ab1f1b7b6fa32be057 100644 (file)
@@ -14,16 +14,15 @@ run_tests:
        done
 
 install: $(TEST_PROGS)
-       @mkdir -p $(DESTDIR)/usr/bin
-       @mkdir -p $(DESTDIR)/usr/share/kselftest
+       @mkdir -p $(DESTDIR)/usr/share/kselftest/ynl
        @cp ../../../testing/selftests/kselftest/ktap_helpers.sh $(DESTDIR)/usr/share/kselftest/
        @for test in $(TEST_PROGS); do \
-               name=$$(basename $$test .sh); \
+               name=$$(basename $$test); \
                sed -e 's|^ynl=.*|ynl="ynl"|' \
                    -e 's|^ynl_ethtool=.*|ynl_ethtool="ynl-ethtool"|' \
                    -e 's|KSELFTEST_KTAP_HELPERS=.*|KSELFTEST_KTAP_HELPERS="/usr/share/kselftest/ktap_helpers.sh"|' \
-                   $$test > $(DESTDIR)/usr/bin/$$name; \
-               chmod +x $(DESTDIR)/usr/bin/$$name; \
+                   $$test > $(DESTDIR)/usr/share/kselftest/ynl/$$name; \
+               chmod +x $(DESTDIR)/usr/share/kselftest/ynl/$$name; \
        done
 
 clean distclean: