]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
time: test: Fix incorrect format specifier
authorDavid Gow <davidgow@google.com>
Wed, 21 Feb 2024 09:27:17 +0000 (17:27 +0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:21:15 +0000 (18:21 -0400)
[ Upstream commit 133e267ef4a26d19c93996a874714e9f3f8c70aa ]

'days' is a s64 (from div_s64), and so should use a %lld specifier.

This was found by extending KUnit's assertion macros to use gcc's
__printf attribute.

Fixes: 276010551664 ("time: Improve performance of time64_to_tm()")
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/time/time_test.c

index 831e8e779acef50cdcb5ced72b039fdd621ad0d4..f7c3de01197c91dfec56a2e7bf6420639f18d756 100644 (file)
@@ -73,7 +73,7 @@ static void time64_to_tm_test_date_range(struct kunit *test)
 
                days = div_s64(secs, 86400);
 
-               #define FAIL_MSG "%05ld/%02d/%02d (%2d) : %ld", \
+               #define FAIL_MSG "%05ld/%02d/%02d (%2d) : %lld", \
                        year, month, mdday, yday, days
 
                KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);