]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: qcom: sa8775p: fix RPMh power domain indices
authorDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Fri, 18 Jul 2025 15:25:38 +0000 (18:25 +0300)
committerBjorn Andersson <andersson@kernel.org>
Mon, 11 Aug 2025 02:01:15 +0000 (21:01 -0500)
On SA8775P power domains device doesn't use unufied (RPMHPD_foo) ABI,
but it uses SoC-specific indices (SA8775P_foo). Consequently, all DSP on
that platform are referencing random PDs instead of the expected ones.

Correct indices used for that platform.

Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20250718-fix-rpmhpd-abi-v2-1-0059edb9ddb3@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sa8775p.dtsi

index fed34717460f060e6a9dfdd4e29ca4025c401b83..f3bd8c9ad2eeebd7a309183b0f19e34cb3c8403e 100644 (file)
@@ -17,7 +17,6 @@
 #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h>
 #include <dt-bindings/mailbox/qcom-ipcc.h>
 #include <dt-bindings/firmware/qcom,scm.h>
-#include <dt-bindings/power/qcom,rpmhpd.h>
 #include <dt-bindings/power/qcom-rpmpd.h>
 #include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
                        clocks = <&rpmhcc RPMH_CXO_CLK>;
                        clock-names = "xo";
 
-                       power-domains = <&rpmhpd RPMHPD_CX>,
-                                       <&rpmhpd RPMHPD_MXC>;
+                       power-domains = <&rpmhpd SA8775P_CX>,
+                                       <&rpmhpd SA8775P_MXC>;
                        power-domain-names = "cx", "mxc";
 
                        interconnects = <&gpdsp_anoc MASTER_DSP0 0
                        clocks = <&rpmhcc RPMH_CXO_CLK>;
                        clock-names = "xo";
 
-                       power-domains = <&rpmhpd RPMHPD_CX>,
-                                       <&rpmhpd RPMHPD_MXC>;
+                       power-domains = <&rpmhpd SA8775P_CX>,
+                                       <&rpmhpd SA8775P_MXC>;
                        power-domain-names = "cx", "mxc";
 
                        interconnects = <&gpdsp_anoc MASTER_DSP1 0
                        clocks = <&rpmhcc RPMH_CXO_CLK>;
                        clock-names = "xo";
 
-                       power-domains = <&rpmhpd RPMHPD_CX>,
-                                       <&rpmhpd RPMHPD_MXC>,
-                                       <&rpmhpd RPMHPD_NSP0>;
+                       power-domains = <&rpmhpd SA8775P_CX>,
+                                       <&rpmhpd SA8775P_MXC>,
+                                       <&rpmhpd SA8775P_NSP0>;
                        power-domain-names = "cx", "mxc", "nsp";
 
                        interconnects = <&nspa_noc MASTER_CDSP_PROC 0
                        clocks = <&rpmhcc RPMH_CXO_CLK>;
                        clock-names = "xo";
 
-                       power-domains = <&rpmhpd RPMHPD_CX>,
-                                       <&rpmhpd RPMHPD_MXC>,
-                                       <&rpmhpd RPMHPD_NSP1>;
+                       power-domains = <&rpmhpd SA8775P_CX>,
+                                       <&rpmhpd SA8775P_MXC>,
+                                       <&rpmhpd SA8775P_NSP1>;
                        power-domain-names = "cx", "mxc", "nsp";
 
                        interconnects = <&nspb_noc MASTER_CDSP_PROC_B 0
                        clocks = <&rpmhcc RPMH_CXO_CLK>;
                        clock-names = "xo";
 
-                       power-domains = <&rpmhpd RPMHPD_LCX>,
-                                       <&rpmhpd RPMHPD_LMX>;
+                       power-domains = <&rpmhpd SA8775P_LCX>,
+                                       <&rpmhpd SA8775P_LMX>;
                        power-domain-names = "lcx", "lmx";
 
                        interconnects = <&lpass_ag_noc MASTER_LPASS_PROC 0 &mc_virt SLAVE_EBI1 0>;