]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
regulator: core: Release coupled_rdevs on regulator_init_coupling() error
authorDmitry Osipenko <digetx@gmail.com>
Fri, 25 Oct 2019 00:22:39 +0000 (03:22 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Dec 2019 15:44:24 +0000 (16:44 +0100)
[ Upstream commit 26c2c997aa1a6c5522f6619910ba025e53e69763 ]

This patch fixes memory leak which should happen if regulator's coupling
fails to initialize.

Fixes: d8ca7d184b33 ("regulator: core: Introduce API for regulators coupling customization")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/20191025002240.25288-1-digetx@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/core.c

index a46be221dbdcba78160781d223c7ee6e2f2f5665..51ce280c1ce1360d1bf9a503cfb88b8e88a66fe2 100644 (file)
@@ -5198,6 +5198,7 @@ unset_supplies:
        regulator_remove_coupling(rdev);
        mutex_unlock(&regulator_list_mutex);
 wash:
+       kfree(rdev->coupling_desc.coupled_rdevs);
        kfree(rdev->constraints);
        mutex_lock(&regulator_list_mutex);
        regulator_ena_gpio_free(rdev);