]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pytest/samba_tool_drs: use TestCaseInTempDir.rm_files/.rm_dirs
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 8 Jun 2022 07:53:57 +0000 (19:53 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Tue, 6 Sep 2022 21:12:36 +0000 (21:12 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
source4/torture/drs/python/samba_tool_drs.py

index ac97162e23d0b6a69aac201636d92fc471a0f790..8538c3041a45756376325e437fdd8bb19a5db30b 100644 (file)
@@ -19,7 +19,6 @@
 """Blackbox tests for samba-tool drs."""
 
 import samba.tests
-import shutil
 import os
 import ldb
 import drs_base
@@ -42,15 +41,9 @@ class SambaToolDrsTests(drs_base.DrsBaseTestCase):
         self._enable_inbound_repl(self.dnsname_dc1)
         self._enable_inbound_repl(self.dnsname_dc2)
 
-        try:
-            shutil.rmtree(os.path.join(self.tempdir, "private"))
-            shutil.rmtree(os.path.join(self.tempdir, "etc"))
-            shutil.rmtree(os.path.join(self.tempdir, "msg.lock"))
-            os.remove(os.path.join(self.tempdir, "names.tdb"))
-            shutil.rmtree(os.path.join(self.tempdir, "state"))
-            shutil.rmtree(os.path.join(self.tempdir, "bind-dns"))
-        except Exception:
-            pass
+        self.rm_files('names.tdb', allow_missing=True)
+        self.rm_dirs('etc', 'msg.lock', 'private', 'state', 'bind-dns',
+                     allow_missing=True)
 
         super(SambaToolDrsTests, self).tearDown()