]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: b44: always select CONFIG_FIXED_PHY
authorArnd Bergmann <arnd@arndb.de>
Fri, 20 Mar 2026 15:49:19 +0000 (16:49 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 24 Mar 2026 00:47:14 +0000 (17:47 -0700)
When CONFIG_FIXED_PHY=m but CONFIG_B44=y, the kernel fails to link:

ld.lld: error: undefined symbol: fixed_phy_unregister
>>> referenced by b44.c
>>>               drivers/net/ethernet/broadcom/b44.o:(b44_remove_one) in archive vmlinux.a

ld.lld: error: undefined symbol: fixed_phy_register_100fd
>>> referenced by b44.c
>>>               drivers/net/ethernet/broadcom/b44.o:(b44_register_phy_one) in archive vmlinux.a

The fixed phy support is small enough that just always enabling it
for b44 is the simplest solution, and it avoids adding ugly #ifdef
checks.

Fixes: 10d2f15afba2 ("net: b44: register a fixed phy using fixed_phy_register_100fd if needed")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20260320154927.674555-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/Kconfig

index cd7dddeb91dd6749fc1fce08adca031a6a1852a3..9787c1857e13bf23fd3ea1d6a88c12703bdc0b9a 100644 (file)
@@ -25,7 +25,7 @@ config B44
        select SSB
        select MII
        select PHYLIB
-       select FIXED_PHY if BCM47XX
+       select FIXED_PHY
        help
          If you have a network (Ethernet) controller of this type, say Y
          or M here.