]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
Windows autolaunch: Turn stdout spam into stderr spam
authorSimon McVittie <smcv@collabora.com>
Tue, 14 Nov 2017 14:11:25 +0000 (14:11 +0000)
committerSimon McVittie <smcv@collabora.com>
Wed, 15 Nov 2017 12:07:47 +0000 (12:07 +0000)
This is still not how warnings and diagnostics should be done
(the advice should probably be included in the DBusError) but at least
this way it won't interfere with machine-readable output on stdout.
See also https://bugs.freedesktop.org/show_bug.cgi?id=103756

Reviewed-by: Philip Withnall <withnall@endlessm.com>
[smcv: Added a reference to #103756]
Signed-off-by: Simon McVittie <smcv@collabora.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103601

dbus/dbus-sysdeps-win.c

index 980b431e3f990ed7a51cbde900cb7107e2970862..90a55a7c00083a8cca5811ce8f025a08baff0c60 100644 (file)
@@ -3082,8 +3082,8 @@ _dbus_get_autolaunch_address (const char *scope, DBusString *address,
             {
               dbus_set_error_const (error, DBUS_ERROR_FAILED, "could not find dbus-daemon executable");
               retval = FALSE;
-              printf ("please add the path to %s to your PATH environment variable\n", daemon_name);
-              printf ("or start the daemon manually\n\n");
+              fprintf (stderr, "please add the path to %s to your PATH environment variable\n", daemon_name);
+              fprintf (stderr, "or start the daemon manually\n\n");
               goto out;
             }
           _dbus_verbose( "found dbus daemon executable at %s",dbus_module_path);