]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resou...
authorChen Ni <nichen@iscas.ac.cn>
Mon, 9 Feb 2026 01:59:04 +0000 (09:59 +0800)
committerChristophe Leroy (CS GROUP) <chleroy@kernel.org>
Mon, 23 Feb 2026 13:49:27 +0000 (14:49 +0100)
Fix wrong variable used for error checking after devm_ioremap_resource()
call. The function checks qmc->scc_pram instead of qmc->dpram, which
could lead to incorrect error handling.

Fixes: eb680d563089 ("soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementation")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20260209015904.871269-1-nichen@iscas.ac.cn
Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
drivers/soc/fsl/qe/qmc.c

index c4587b32a59bfa2652a581c62b3fdd871f3471b9..672adff8e35f4c1ede16f369e45f1f2f5624646b 100644 (file)
@@ -1790,8 +1790,8 @@ static int qmc_qe_init_resources(struct qmc *qmc, struct platform_device *pdev)
                return -EINVAL;
        qmc->dpram_offset = res->start - qe_muram_dma(qe_muram_addr(0));
        qmc->dpram = devm_ioremap_resource(qmc->dev, res);
-       if (IS_ERR(qmc->scc_pram))
-               return PTR_ERR(qmc->scc_pram);
+       if (IS_ERR(qmc->dpram))
+               return PTR_ERR(qmc->dpram);
 
        return 0;
 }