]> git.ipfire.org Git - thirdparty/valgrind.git/commitdiff
DARWIN sync: comment and braces.
authorNicholas Nethercote <njn@valgrind.org>
Fri, 22 May 2009 07:09:03 +0000 (07:09 +0000)
committerNicholas Nethercote <njn@valgrind.org>
Fri, 22 May 2009 07:09:03 +0000 (07:09 +0000)
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10102

coregrind/m_syswrap/syswrap-generic.c

index 3290785b1b0c5580d301512a6f0d6ba5e780b26b..ffce2923c842cbf3954dca48ebb66118ce3b9298 100644 (file)
@@ -1180,9 +1180,13 @@ Bool ML_(fd_allowed)(Int fd, const Char *syscallname, ThreadId tid, Bool isNewFd
       VG_(message)(Vg_UserMsg, 
          "Warning: invalid file descriptor %d in syscall %s()",
          fd, syscallname);
-      if (fd == VG_(clo_log_fd))
+      if (fd == VG_(clo_log_fd)) {
         VG_(message)(Vg_UserMsg, 
             "   Use --log-fd=<number> to select an alternative log fd.");
+      }
+      // DDD: consider always printing this stack trace, it's useful.
+      // Also consider also making this a proper core error, ie.
+      // suppressible and all that.
       if (VG_(clo_verbosity) > 1) {
          VG_(get_and_pp_StackTrace)(tid, VG_(clo_backtrace_size));
       }