vfs_streams_xattr: Fix CID 1667321 REVERSE_INULL

Remove NULL check for fsp. A NULL fsp is a fatal error
that should never occur in this context.

Signed-off-by: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Wed Oct 29 14:43:28 UTC 2025 on atb-devel-224

diff --git a/source3/modules/vfs_streams_xattr.c b/source3/modules/vfs_streams_xattr.c
index 9eb2d0068b566ca161b2cd6f5d80e047f2cf2361..f892bc45c66eaf38ca3974f362990ef9d0a7be0b 100644 (file)
--- a/source3/modules/vfs_streams_xattr.c
+++ b/source3/modules/vfs_streams_xattr.c
@@ -419,9 +419,6 @@ static int streams_xattr_get_ea_value_fsp(
        ssize_t sizeret;
        bool refuse;
 
-       if (fsp == NULL) {
-               return EINVAL;
-       }
        refuse = refuse_symlink_fsp(fsp);
        if (refuse) {
                return EACCES;