]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-134262: increase retries in `Tools/build/generate_sbom.py` (#134558)
authorEmma Smith <emma@emmatyping.dev>
Tue, 27 May 2025 16:02:17 +0000 (09:02 -0700)
committerGitHub <noreply@github.com>
Tue, 27 May 2025 16:02:17 +0000 (19:02 +0300)
Tools/build/generate_sbom.py

index 5845f2d85c7fdbef3acb802332bfbb5f9f54cf51..ecb7b54f6d8a13b12ed1443d990d623ea80ed312 100644 (file)
@@ -4,6 +4,7 @@ import glob
 import hashlib
 import json
 import os
+import random
 import re
 import subprocess
 import sys
@@ -164,16 +165,18 @@ def get_externals() -> list[str]:
 
 
 def download_with_retries(download_location: str,
-                          max_retries: int = 5,
-                          base_delay: float = 2.0) -> typing.Any:
+                          max_retries: int = 7,
+                          base_delay: float = 2.25,
+                          max_jitter: float = 1.0) -> typing.Any:
     """Download a file with exponential backoff retry."""
     for attempt in range(max_retries):
         try:
             resp = urllib.request.urlopen(download_location)
         except urllib.error.URLError as ex:
             if attempt == max_retries:
-                raise ex
-            time.sleep(base_delay**attempt)
+                msg = f"Download from {download_location} failed."
+                raise OSError(msg) from ex
+            time.sleep(base_delay**attempt + random.uniform(0, max_jitter))
         else:
             return resp