]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.9-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 May 2020 16:50:07 +0000 (18:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 May 2020 16:50:07 +0000 (18:50 +0200)
added patches:
sctp-fix-shutdown-ctsn-ack-in-the-peer-restart-case.patch

queue-4.9/sctp-fix-shutdown-ctsn-ack-in-the-peer-restart-case.patch [new file with mode: 0644]
queue-4.9/series

diff --git a/queue-4.9/sctp-fix-shutdown-ctsn-ack-in-the-peer-restart-case.patch b/queue-4.9/sctp-fix-shutdown-ctsn-ack-in-the-peer-restart-case.patch
new file mode 100644 (file)
index 0000000..450d0f7
--- /dev/null
@@ -0,0 +1,45 @@
+From 12dfd78e3a74825e6f0bc8df7ef9f938fbc6bfe3 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jere=20Lepp=C3=A4nen?= <jere.leppanen@nokia.com>
+Date: Tue, 21 Apr 2020 22:03:42 +0300
+Subject: sctp: Fix SHUTDOWN CTSN Ack in the peer restart case
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Jere Leppänen <jere.leppanen@nokia.com>
+
+commit 12dfd78e3a74825e6f0bc8df7ef9f938fbc6bfe3 upstream.
+
+When starting shutdown in sctp_sf_do_dupcook_a(), get the value for
+SHUTDOWN Cumulative TSN Ack from the new association, which is
+reconstructed from the cookie, instead of the old association, which
+the peer doesn't have anymore.
+
+Otherwise the SHUTDOWN is either ignored or replied to with an ABORT
+by the peer because CTSN Ack doesn't match the peer's Initial TSN.
+
+Fixes: bdf6fa52f01b ("sctp: handle association restarts when the socket is closed.")
+Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com>
+Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
+Signed-off-by: David S. Miller <davem@davemloft.net>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ net/sctp/sm_make_chunk.c |    6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+--- a/net/sctp/sm_make_chunk.c
++++ b/net/sctp/sm_make_chunk.c
+@@ -856,7 +856,11 @@ struct sctp_chunk *sctp_make_shutdown(co
+       sctp_shutdownhdr_t shut;
+       __u32 ctsn;
+-      ctsn = sctp_tsnmap_get_ctsn(&asoc->peer.tsn_map);
++      if (chunk && chunk->asoc)
++              ctsn = sctp_tsnmap_get_ctsn(&chunk->asoc->peer.tsn_map);
++      else
++              ctsn = sctp_tsnmap_get_ctsn(&asoc->peer.tsn_map);
++
+       shut.cum_tsn_ack = htonl(ctsn);
+       retval = sctp_make_control(asoc, SCTP_CID_SHUTDOWN, 0,
index 8d4bd152f93f9078ac7fd1e1569447646b0c47f1..8b90ddc61704dba65670fc489aabf81e8d308afc 100644 (file)
@@ -13,3 +13,4 @@ net-bcmgenet-suppress-warnings-on-failed-rx-skb-allo.patch
 net-systemport-suppress-warnings-on-failed-rx-skb-al.patch
 xprtrdma-fix-backchannel-allocation-of-extra-rpcrdma_reps.patch
 mips-perf-remove-incorrect-odd-even-counter-handling-for-i6400.patch
+sctp-fix-shutdown-ctsn-ack-in-the-peer-restart-case.patch