shared/install-printf: fix memleak

instance might be "", and that string would be leaked.

CID #1368264.

diff --git a/src/shared/install-printf.c b/src/shared/install-printf.c
index 823fb61cdadc3dc9f55c6f007dc4cfd89ad6c949..c10ed3d311a2d3a9edcc6fb660be91202016f004 100644 (file)
--- a/src/shared/install-printf.c
+++ b/src/shared/install-printf.c
@@ -93,9 +93,9 @@ static int specifier_instance(char specifier, void *data, void *userdata, char *
                 return r;
 
         if (isempty(instance)) {
-                instance = strdup(i->default_instance ?: "");
-                if (!instance)
-                        return -ENOMEM;
+                r = free_and_strdup(&instance, i->default_instance ?: "");
+                if (r < 0)
+                        return r;
         }
 
         *ret = instance;