iio: adc: stm32-adc: Fix race in installing chained IRQ handler

commit e8ad595064f6ebd5d2d1a5d5d7ebe0efce623091 upstream.

Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Fixes: 1add69880240 ("iio: adc: Add support for STM32 ADC core")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Tested-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://patch.msgid.link/20250515083101.3811350-1-nichen@iscas.ac.cn
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 616dd729666aa1129c465e040ab701956d91d4ec..97ea15cba9f7a92a9db3000bbb15d9c0d215b3ba 100644 (file)
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -429,10 +429,9 @@ static int stm32_adc_irq_probe(struct platform_device *pdev,
                return -ENOMEM;
        }
 
-       for (i = 0; i < priv->cfg->num_irqs; i++) {
-               irq_set_chained_handler(priv->irq[i], stm32_adc_irq_handler);
-               irq_set_handler_data(priv->irq[i], priv);
-       }
+       for (i = 0; i < priv->cfg->num_irqs; i++)
+               irq_set_chained_handler_and_data(priv->irq[i],
+                                                stm32_adc_irq_handler, priv);
 
        return 0;
 }