]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: downgrade inability to send varlink reply error message
authorLennart Poettering <lennart@poettering.net>
Tue, 3 Jan 2023 15:26:55 +0000 (16:26 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Tue, 3 Jan 2023 22:12:02 +0000 (23:12 +0100)
Previously, if a client disconnected after sending a lookup request but
before waiting for the reply we'd log at LOG_ERR level. That's
confusing, since it's entirely OK for the client to lose interest.

Hence, let's downgrade to debug level.

Fixes: #25892
src/resolve/resolved-varlink.c

index 8ba5eb9833e37538dfc1916255ac16271479e83f..f878d9ee3fe57e804084a547f01b5614e7c2ed9f 100644 (file)
@@ -243,7 +243,7 @@ static void vl_method_resolve_hostname_complete(DnsQuery *query) {
                                            JSON_BUILD_PAIR("flags", JSON_BUILD_INTEGER(dns_query_reply_flags_make(q)))));
 finish:
         if (r < 0) {
-                log_error_errno(r, "Failed to send hostname reply: %m");
+                log_full_errno(ERRNO_IS_DISCONNECT(r) ? LOG_DEBUG : LOG_ERR, r, "Failed to send hostname reply: %m");
                 r = varlink_error_errno(q->varlink_request, r);
         }
 }
@@ -462,7 +462,7 @@ static void vl_method_resolve_address_complete(DnsQuery *query) {
                                            JSON_BUILD_PAIR("flags", JSON_BUILD_INTEGER(dns_query_reply_flags_make(q)))));
 finish:
         if (r < 0) {
-                log_error_errno(r, "Failed to send address reply: %m");
+                log_full_errno(ERRNO_IS_DISCONNECT(r) ? LOG_DEBUG : LOG_ERR, r, "Failed to send address reply: %m");
                 r = varlink_error_errno(q->varlink_request, r);
         }
 }