]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
kaiser: ENOMEM if kaiser_pagetable_walk() NULL
authorHugh Dickins <hughd@google.com>
Mon, 4 Sep 2017 01:48:02 +0000 (18:48 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jan 2018 14:44:24 +0000 (15:44 +0100)
kaiser_add_user_map() took no notice when kaiser_pagetable_walk() failed.
And avoid its might_sleep() when atomic (though atomic at present unused).

Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/mm/kaiser.c

index da2fdd3c70102dc765cb7b1e6e72599b392a08c0..57e3a7dd4708c01720ae6df54197266ba1a4debe 100644 (file)
@@ -99,11 +99,11 @@ static pte_t *kaiser_pagetable_walk(unsigned long address, bool is_atomic)
        pgd_t *pgd = native_get_shadow_pgd(pgd_offset_k(address));
        gfp_t gfp = (GFP_KERNEL | __GFP_NOTRACK | __GFP_ZERO);
 
-       might_sleep();
        if (is_atomic) {
                gfp &= ~GFP_KERNEL;
                gfp |= __GFP_HIGH | __GFP_ATOMIC;
-       }
+       } else
+               might_sleep();
 
        if (pgd_none(*pgd)) {
                WARN_ONCE(1, "All shadow pgds should have been populated");
@@ -160,13 +160,17 @@ int kaiser_add_user_map(const void *__start_addr, unsigned long size,
        unsigned long end_addr = PAGE_ALIGN(start_addr + size);
        unsigned long target_address;
 
-       for (;address < end_addr; address += PAGE_SIZE) {
+       for (; address < end_addr; address += PAGE_SIZE) {
                target_address = get_pa_from_mapping(address);
                if (target_address == -1) {
                        ret = -EIO;
                        break;
                }
                pte = kaiser_pagetable_walk(address, false);
+               if (!pte) {
+                       ret = -ENOMEM;
+                       break;
+               }
                if (pte_none(*pte)) {
                        set_pte(pte, __pte(flags | target_address));
                } else {