PR 7044

        * dlltool.c (run): Use formatting string to avoid compile time
        warning.
        (gen_exp_file): Check return value from fread.
        * windmc.c (main): Check return value from fread.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 62166f110df55ad2a5b2751bb95108911928aa22..c85fdf285fa7dd309fb8734d6e196cc8e3bdaeae 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,11 @@
+2008-12-01  Nick Clifton  <nickc@redhat.com>
+
+       PR 7044
+       * dlltool.c (run): Use formatting string to avoid compile time
+       warning.
+       (gen_exp_file): Check return value from fread.
+       * windmc.c (main): Check return value from fread.
+
 2008-09-25  Richard Henderson  <rth@redhat.com>
 
        * dwarf.c (size_of_encoded_value, get_encoded_value): Move up.

diff --git a/binutils/dlltool.c b/binutils/dlltool.c
index 505402bf663aebf4df2459ee776b84d5ef76a3e4..16e7c595e2067afc262b537c46471a0878b17f17 100644 (file)
--- a/binutils/dlltool.c
+++ b/binutils/dlltool.c
@@ -1206,7 +1206,7 @@ run (const char *what, char *args)
 
   if (pid == -1)
     {
-      inform (strerror (errno));
+      inform ("%s", strerror (errno));
 
       fatal (errmsg_fmt, errmsg_arg);
     }
@@ -1992,10 +1992,10 @@ gen_exp_file (void)
       numbytes = ftell (base_file);
       fseek (base_file, 0, SEEK_SET);
       copy = xmalloc (numbytes);
-      fread (copy, 1, numbytes, base_file);
+      if (fread (copy, 1, numbytes, base_file) < numbytes)
+       fatal (_("failed to read the number of entries from base file"));
       num_entries = numbytes / sizeof (long);
 
-
       fprintf (f, "\t.section\t.reloc\n");
       if (num_entries)
        {

diff --git a/binutils/windmc.c b/binutils/windmc.c
index 283c2657506d79dcf875e6046cc8b7c38e0d3977..84dac51dafa26437567613af0d16be55df552bf3 100644 (file)
--- a/binutils/windmc.c
+++ b/binutils/windmc.c
@@ -1155,7 +1155,8 @@ main (int argc, char **argv)
     fseek (fp, 0, SEEK_SET);
     buff = malloc (flen + 3);
     memset (buff, 0, flen + 3);
-    fread (buff, 1, flen, fp);
+    if (fread (buff, 1, flen, fp) < flen)
+      fatal (_("unable to read contents of %s"), input_filename);
     fclose (fp);
     if (mcset_text_in_is_unicode != 1)
       {