]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
gpt-auto-generator: don't eat up errors of generator_enable_remount_fs_service()
authorLennart Poettering <lennart@poettering.net>
Wed, 15 Nov 2023 12:17:31 +0000 (13:17 +0100)
committerLennart Poettering <lennart@poettering.net>
Wed, 15 Nov 2023 12:21:10 +0000 (13:21 +0100)
I cannot see a reason why we should ignore this error, so let's not. We
use RET_GATHER() on the returns anyway, i.e. collect errors but
continue, so it makes sense to collect this one too.

src/gpt-auto-generator/gpt-auto-generator.c

index d1f6688f4ca6db0c1c32ddef87c0f805a4d0a51f..b2c78ef4c2b6724c56f88d34ae65f756aeb2e91f 100644 (file)
@@ -648,7 +648,9 @@ static int add_partition_root_rw(DissectedPartition *p) {
                 return 0;
         }
 
-        (void) generator_enable_remount_fs_service(arg_dest);
+        r = generator_enable_remount_fs_service(arg_dest);
+        if (r < 0)
+                return r;
 
         path = strjoina(arg_dest, "/systemd-remount-fs.service.d/50-remount-rw.conf");